linux-kernel - Re: [PATCH 3/3] x86/mm: Cleanup prctl_enable_tagged_addr() nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jnpv2ijtmiq4ubnimt7ofgq7pjbygyq3ggqsppgqcqvwigdnpr@urnckuntqx2i>
Date: Tue, 12 Mar 2024 14:36:19 +0200
From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To: Yosry Ahmed <yosryahmed@...gle.com>
Cc: x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>, 
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>, 
	Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>, 
	Rick Edgecombe <rick.p.edgecombe@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] x86/mm: Cleanup prctl_enable_tagged_addr() nr_bits
 error checking

On Tue, Mar 12, 2024 at 03:59:51AM +0000, Yosry Ahmed wrote:
> There are two separate checks in prctl_enable_tagged_addr() that nr_bits
> is in the correct range. The checks are arranged such the correct case
> is sandwiched between both error cases, which do exactly the same thing.
> 
> Simplify the if condition and pull the correct case outside with the
> rest of the success code path.
> 
> Signed-off-by: Yosry Ahmed <yosryahmed@...gle.com>

Reviewed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov