linux-kernel - Re: [PATCH] staging: p80211conv: Rename local foo to decrypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK=vLxJLOsqECJn+c=Mo0kY2878u1bhRzYEWo+yZZEUbqEee7g@mail.gmail.com>
Date: Tue, 12 Mar 2024 15:16:08 +0100
From: Felix Kimbu <felixkimbu1@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check

On Tue, Mar 12, 2024 at 10:03 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> With the rename the indenting did need to be updated, yes.  However it
> should have been:
>
>                 decrypt_check = wep_encrypt(wlandev, skb->data, p80211_wep->data,
>                                             skb->len,
>                                             wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK,
>                                             p80211_wep->iv, p80211_wep->icv);
>
> [tab][tab][tab][tab][tab][space][space][space][space]skb->len,
>
> See my blog for how to resend a patch:
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
>
> regards,
> dan carpenter

Thank you for the feedback, Dan, let me correct that.