[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dff13df4-39c4-4995-b7cf-f9240a970cbc@sirena.org.uk>
Date: Tue, 12 Mar 2024 14:31:37 +0000
From: Mark Brown <broonie@...nel.org>
To: xuhanwu <2433926602@...com>
Cc: lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
xuhanwu <xu.hanwu@...lec.com>
Subject: Re: [PATCH] ASoC: soc-pcm: add a check for unsupported commands to
the soc_pcm_trigger
On Mon, Mar 11, 2024 at 03:05:48PM +0800, xuhanwu wrote:
> > As can be seen from inspection of the immediately
> > preceeding handling of start, we're deliberately
> > ignoring half the values in each switch.
> In kernel version 6.2, when the soc_pcm_trigger function receives a
> command parameter cmd set to SNDRV_PCM_TRIGGER_DRAIN,
> it returns a value of -EINVAL.The function snd_pcm_drain checks
> the returned error value and exits accordingly.
The current kernel version is v6.8 (we're in the merge window for v6.9
now) - any changes that you're submitting should be submitted against
current code, not v6.2.
> In the latest code, when the cmd parameter is set to SNDRV_PCM_TRIGGER_DRAIN,
> the return value is 0. If snd_pcm_drain finds that the return value is 0,
> it will not execute the goto unlock;
Well, it will get to the unlock eventually after going through the for
loop so the lock doesn't get leaked AFAICT? I'm not sure what the issue
you're seeing here is.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists