linux-kernel - Re: [PATCH] selftests: x86: skip the tests if prerequisites aren't fulfilled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf4cb384-97ce-4782-b6b9-e75780cdf167@linux.intel.com>
Date: Tue, 12 Mar 2024 08:10:14 +0800
From: Binbin Wu <binbin.wu@...ux.intel.com>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: Shuah Khan <shuah@...nel.org>, "Chang S. Bae" <chang.seok.bae@...el.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
 "Peter Zijlstra (Intel)" <peterz@...radead.org>,
 Weihong Zhang <weihong.zhang@...el.com>, angquan yu <angquan21@...il.com>,
 kernel@...labora.com, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: x86: skip the tests if prerequisites aren't
 fulfilled

On 3/8/2024 2:37 AM, Muhammad Usama Anjum wrote:
> diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/x86/lam.c
> index 215b8150b7cca..c0f016f45ee17 100644
> --- a/tools/testing/selftests/x86/lam.c
> +++ b/tools/testing/selftests/x86/lam.c
> @@ -1183,7 +1183,7 @@ int main(int argc, char **argv)
>   
>   	if (!cpu_has_lam()) {
>   		ksft_print_msg("Unsupported LAM feature!\n");
> -		return -1;
> +		return KSFT_SKIP;
>   	}
>   
>   	while ((c = getopt(argc, argv, "ht:")) != -1) {
Looks good to me.
Reviewed-by: Binbin Wu <binbin.wu@...ux.intel.com>