linux-kernel - Re: [PATCH 2/7] of: Create of_root if no dtb provided by firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e83b606a-e34e-423f-b26b-df745052d06b@sirena.org.uk>
Date: Tue, 12 Mar 2024 14:44:19 +0000
From: Mark Brown <broonie@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Rob Herring <robh+dt@...nel.org>,
	Saurabh Singh Sengar <ssengar@...ux.microsoft.com>,
	Frank Rowand <frowand.list@...il.com>, linux-kernel@...r.kernel.org,
	patches@...ts.linux.dev, linux-um@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, kunit-dev@...glegroups.com,
	linux-kselftest@...r.kernel.org, devicetree@...r.kernel.org,
	"Gabriel L. Somlo" <gsomlo@...il.com>
Subject: Re: [PATCH 2/7] of: Create of_root if no dtb provided by firmware

On Tue, Mar 12, 2024 at 03:41:32PM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 21, 2024 at 3:06 PM Rob Herring <robh+dt@...nel.org> wrote:

>     static int __init regulator_init_complete(void)
>     {
>             /*
>              * Since DT doesn't provide an idiomatic mechanism for
>              * enabling full constraints and since it's much more natural
>              * with DT to provide them just assume that a DT enabled
>              * system has full constraints.
>              */
>             if (of_have_populated_dt())
>                     has_full_constraints = true;
> 
>             ...
>     }
>     late_initcall_sync(regulator_init_complete);

> (The latter looks a bit futile, as have_full_constraints() already
>  contains a check for of_have_populated_dt()?)

Yes, it's duplicated and we should remove it.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)