linux-kernel - Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZfB2Y1P5VRZWEUqu@smile.fi.intel.com>
Date: Tue, 12 Mar 2024 17:36:03 +0200
From: Andy Shevchenko <andy@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, Paul Burton <paulburton@...nel.org>
Subject: Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Convert to platform
 remove callback returning void

On Tue, Mar 12, 2024 at 11:27:37AM +0100, Uwe Kleine-König wrote:
> On Tue, Mar 12, 2024 at 09:17:54AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Mar 11, 2024 at 10:59 PM Uwe Kleine-König
> > <u.kleine-koenig@...gutronix.de> wrote:
> > > The .remove() callback for a platform driver returns an int which makes
> > > many driver authors wrongly assume it's possible to do error handling by
> > > returning an error code. However the value returned is ignored (apart
> > > from emitting a warning) and this typically results in resource leaks.
> > >
> > > To improve here there is a quest to make the remove callback return
> > > void. In the first step of this quest all drivers are converted to
> > > .remove_new(), which already returns void. Eventually after all drivers
> > > are converted, .remove_new() will be renamed to .remove().
> > >
> > > Trivially convert this driver from always returning zero in the remove
> > > callback to the void returning variant.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > 
> > Thanks for your patch!
> > 
> > > --- a/drivers/auxdisplay/img-ascii-lcd.c
> > > +++ b/drivers/auxdisplay/img-ascii-lcd.c
> > > @@ -279,13 +279,12 @@ static int img_ascii_lcd_probe(struct platform_device *pdev)
> > >   *
> > >   * Return: 0
> > 
> > Please remove this line.
> 
> Good catch, thanks.
> 
> @Andy: Should I resend this patch? Or the whole series? Or do you want
> to fixup while applying?

Not big deal, I'll fix it whilst applying.
Thank you!

-- 
With Best Regards,
Andy Shevchenko