linux-kernel - RE: [EXTERNAL] Re: [PATCH 2/3] net: marvell: prestera: fix memory use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 12 Mar 2024 16:51:05 +0000
From: Elad Nachman <enachman@...vell.com>
To: Kory Maincent <kory.maincent@...tlin.com>
CC: Taras Chornyi <taras.chornyi@...ision.eu>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "thomas.petazzoni@...tlin.com"
	<thomas.petazzoni@...tlin.com>,
        "miquel.raynal@...tlin.com"
	<miquel.raynal@...tlin.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH 2/3] net: marvell: prestera: fix memory use
 after free



> -----Original Message-----
> From: Kory Maincent <kory.maincent@...tlin.com>
> Sent: Tuesday, March 12, 2024 5:45 PM
> To: Elad Nachman <enachman@...vell.com>
> Cc: Taras Chornyi <taras.chornyi@...ision.eu>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> andrew@...n.ch; thomas.petazzoni@...tlin.com;
> miquel.raynal@...tlin.com; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [EXTERNAL] Re: [PATCH 2/3] net: marvell: prestera: fix memory use
> after free
> 
> Prioritize security for external emails: Confirm sender and content safety
> before clicking links or opening attachments
> 
> ----------------------------------------------------------------------
> On Mon, 11 Mar 2024 15:51:11 +0200
> Elad Nachman <enachman@...vell.com> wrote:
> 
> > From: Elad Nachman <enachman@...vell.com>
> >
> > Prestera driver routing module cleanup process would release memory
> > and then reference it again, and eventually free it again.
> > Remove the redundant first memory free call.
> > All such double free calls were detected using KASAN.
> 
> Not directly related to this patch but I am wondering if the call to
> prestera_port_sfp_unbind(port) is not missing in
> prestera_destroy_ports() function?

Yes, it is.

> 
> Regards,
> --
> Köry Maincent, Bootlin
> Embedded Linux and kernel engineering
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__bootlin.com&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=eTeNTLEK5-
> TxXczjOcKPhANIFtlB9pP4lq9qhdlFrwQ&m=VnjwUBq4QS_Onl_07gp1OUp2XoG
> pT-
> bZ5snEOAg5gf3CM3l5GPgXQ1pb3GzEa6bb&s=GchzqI3lHyGuFKhepEFMFsXwp
> 5oMSH9iqwBZuTtzhjc&e=

Elad.