linux-kernel - [PATCH] ssb: use "break" on default case to prevent warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240313001305.18820-1-rdunlap@infradead.org>
Date: Tue, 12 Mar 2024 17:13:03 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: linux-kernel@...r.kernel.org
Cc: Randy Dunlap <rdunlap@...radead.org>,
	kernel test robot <lkp@...el.com>,
	Michael Büsch <m@...s.ch>,
	linux-wireless@...r.kernel.org,
	Kalle Valo <kvalo@...nel.org>,
	Johannes Berg <johannes@...solutions.net>,
	llvm@...ts.linux.dev
Subject: [PATCH] ssb: use "break" on default case to prevent warning

Having an empty default: case in a switch statement causes a warning
(when using Clang; I don't see the warning when using gcc),
so add a "break;" to the default case to prevent the warning:

drivers/ssb/main.c:1149:2: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions]

Fixes: e27b02e23a70 ("ssb: drop use of non-existing CONFIG_SSB_DEBUG symbol")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403130717.TWm17FiD-lkp@intel.com/
Cc: Michael Büsch <m@...s.ch>
Cc: linux-wireless@...r.kernel.org
Cc: Kalle Valo <kvalo@...nel.org>
Cc: Johannes Berg <johannes@...solutions.net>
Cc: llvm@...ts.linux.dev
---
 drivers/ssb/main.c |    1 +
 1 file changed, 1 insertion(+)

diff -- a/drivers/ssb/main.c b/drivers/ssb/main.c
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1144,6 +1144,7 @@ u32 ssb_dma_translation(struct ssb_devic
 				return SSB_PCI_DMA;
 		}
 	default:
+		break;
 	}
 	return 0;
 }