linux-kernel - Re: [PATCH v3 08/12] treewide: Use initializer for struct vm_unmapped_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202403122018.DCCE1E000@keescook>
Date: Tue, 12 Mar 2024 20:18:31 -0700
From: Kees Cook <keescook@...omium.org>
To: Rick Edgecombe <rick.p.edgecombe@...el.com>
Cc: Liam.Howlett@...cle.com, akpm@...ux-foundation.org, bp@...en8.de,
	broonie@...nel.org, dave.hansen@...ux.intel.com, debug@...osinc.com,
	hpa@...or.com, kirill.shutemov@...ux.intel.com, luto@...nel.org,
	mingo@...hat.com, peterz@...radead.org, tglx@...utronix.de,
	x86@...nel.org, christophe.leroy@...roup.eu,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-alpha@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-csky@...r.kernel.org,
	loongarch@...ts.linux.dev, linux-mips@...r.kernel.org,
	linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
	sparclinux@...r.kernel.org
Subject: Re: [PATCH v3 08/12] treewide: Use initializer for struct
 vm_unmapped_area_info

On Tue, Mar 12, 2024 at 03:28:39PM -0700, Rick Edgecombe wrote:
> So to be reduce the chance of bugs via uninitialized fields, perform a
> tree wide change using the consensus for the best general way to do this
> change. Use C99 static initializing to zero the struct and remove and
> statements that simply set members to zero.
> 
> Signed-off-by: Rick Edgecombe <rick.p.edgecombe@...el.com>

Thanks! This looks to do exactly what it describes. :)

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook