linux-kernel - Re: [PATCH 2/2] arm64: dts: mediatek: Add missing chassis-type to MT8192 Chromebooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f1ec438-9447-4a5c-b1ee-e9c6938516d1@ixit.cz>
Date: Wed, 13 Mar 2024 20:07:57 +0100
From: David Heidelberg <david@...t.cz>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-mediatek@...ts.infradead.org
Cc: robh@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 matthias.bgg@...il.com, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 kernel@...labora.com
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: Add missing chassis-type to
 MT8192 Chromebooks

Optional, but very useful for some user-space decisions. Thank you.

Reviewed-by: David Heidelberg <david@...t.cz>

On 13/03/2024 15:15, AngeloGioacchino Del Regno wrote:
> None of the MT8192 Chromebooks had their chassis-type specified: add
> the right definition for each.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>   arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts      | 1 +
>   arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts | 1 +
>   arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts    | 1 +
>   arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts    | 1 +
>   4 files changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts
> index fd2cb8765a15..ac2673e56fb8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts
> @@ -7,6 +7,7 @@
>   
>   / {
>   	model = "Google Hayato rev1";
> +	chassis-type = "convertible";
>   	compatible = "google,hayato-rev1", "google,hayato", "mediatek,mt8192";
>   };
>   
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts
> index 3127ee5f6172..cd86ad9ba28a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r5-sku2.dts
> @@ -7,6 +7,7 @@
>   
>   / {
>   	model = "Google Hayato rev5";
> +	chassis-type = "convertible";
>   	compatible = "google,hayato-rev5-sku2", "google,hayato-sku2",
>   		     "google,hayato", "mediatek,mt8192";
>   };
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts
> index bc88866ab2f5..29aa87e93888 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts
> @@ -8,6 +8,7 @@
>   
>   / {
>   	model = "Google Spherion (rev0 - 3)";
> +	chassis-type = "laptop";
>   	compatible = "google,spherion-rev3", "google,spherion-rev2",
>   		     "google,spherion-rev1", "google,spherion-rev0",
>   		     "google,spherion", "mediatek,mt8192";
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts
> index 0039158c9e60..5e9e598bab90 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r4.dts
> @@ -8,6 +8,7 @@
>   
>   / {
>   	model = "Google Spherion (rev4)";
> +	chassis-type = "laptop";
>   	compatible = "google,spherion-rev4", "google,spherion",
>   		     "mediatek,mt8192";
>   

-- 
David Heidelberg