[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA8EJpo63oRA07QNCdzJdHW_hJJWK6aj-LCpp-XwmPJYf0twZw@mail.gmail.com>
Date: Wed, 13 Mar 2024 21:20:35 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Ajit Pandey <quic_ajipan@...cinc.com>,
Imran Shaik <quic_imrashai@...cinc.com>, Taniya Das <quic_tdas@...cinc.com>,
Jagadeesh Kona <quic_jkona@...cinc.com>, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc bindings
On Wed, 13 Mar 2024 at 13:11, Satya Priya Kakitapalli
<quic_skakitap@...cinc.com> wrote:
>
> Update the videocc device tree bindings for sm8150 to align with the
> latest convention.
But why? Bindings already exist. There is nothing wrong with them. And
sm8150 platform in general uses name-based lookup.
>
> Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
It is not a fix, there is no bug that this commit is fixing.
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@...cinc.com>
> ---
> Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 1 +
> Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 3 ---
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> index bad8f019a8d3..e00fdc8ceaa4 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> @@ -20,6 +20,7 @@ properties:
> enum:
> - qcom,sm8450-videocc
> - qcom,sm8550-videocc
> + - qcom,sm8150-videocc
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> index 6999e36ace1b..28d134ad9517 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> @@ -17,7 +17,6 @@ description: |
> include/dt-bindings/clock/qcom,videocc-sc7180.h
> include/dt-bindings/clock/qcom,videocc-sc7280.h
> include/dt-bindings/clock/qcom,videocc-sdm845.h
> - include/dt-bindings/clock/qcom,videocc-sm8150.h
> include/dt-bindings/clock/qcom,videocc-sm8250.h
>
> properties:
> @@ -26,7 +25,6 @@ properties:
> - qcom,sc7180-videocc
> - qcom,sc7280-videocc
> - qcom,sdm845-videocc
> - - qcom,sm8150-videocc
> - qcom,sm8250-videocc
>
> clocks:
> @@ -75,7 +73,6 @@ allOf:
> enum:
> - qcom,sc7180-videocc
> - qcom,sdm845-videocc
> - - qcom,sm8150-videocc
> then:
> properties:
> clocks:
>
> --
> 2.25.1
>
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists