linux-kernel - Re: [PATCH v2 10/15] sched: Fix build error in "sched/rt: Remove default bandwidth control"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0eab402d-f18f-4831-0be3-2ecaea40a62d@oracle.com>
Date: Wed, 13 Mar 2024 16:06:11 -0400
From: Chris Hyser <chris.hyser@...cle.com>
To: "Joel Fernandes (Google)" <joel@...lfernandes.org>,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
        Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira
 <bristot@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>
Cc: Suleiman Souhlal <suleiman@...gle.com>,
        Youssef Esmat <youssefesmat@...gle.com>,
        David Vernet <void@...ifault.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Paul E . McKenney"
 <paulmck@...nel.org>,
        joseph.salisbury@...onical.com,
        Luca Abeni <luca.abeni@...tannapisa.it>,
        Tommaso Cucinotta <tommaso.cucinotta@...tannapisa.it>,
        Vineeth Pillai <vineeth@...byteword.org>,
        Shuah Khan <skhan@...uxfoundation.org>, Phil Auld <pauld@...hat.com>
Subject: Re: [PATCH v2 10/15] sched: Fix build error in "sched/rt: Remove
 default bandwidth control"


On 3/12/24 21:24, Joel Fernandes (Google) wrote:
> This fixes a build error introduced by  "sched/rt: Remove default
> bandwidth control". The issue happens because a function is unused
> when !CONFIG_SMP. It could be squashed into the original patch.
>
> Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>


Reviewed-by: Chris Hyser <chris.hyser@...cle.com>


> ---
>   kernel/sched/rt.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 37bee56a70f7..d3065fe35c61 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -964,8 +964,10 @@ struct rt_rq *sched_rt_period_rt_rq(struct rt_bandwidth *rt_b, int cpu)
>   	return &cpu_rq(cpu)->rt;
>   }
>   
> +#ifdef CONFIG_SMP
>   static void __enable_runtime(struct rq *rq) { }
>   static void __disable_runtime(struct rq *rq) { }
> +#endif
>   
>   #endif /* CONFIG_RT_GROUP_SCHED */
>