linux-kernel - Re: [v1] staging: media: starfive: Clean pad selection in isp_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bd3995b-2625-4874-ab53-fa3bcffb5f28@moroto.mountain>
Date: Wed, 13 Mar 2024 09:01:24 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Jack Zhu <jack.zhu@...rfivetech.com>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [v1] staging: media: starfive: Clean pad selection in
 isp_try_format()

On Mon, Mar 11, 2024 at 07:45:20PM -0700, Changhuang Liang wrote:
> The code to select isp_dev->formats[] is overly complicated.  We can
> just use the "pad" as the index.  This will making adding new pads
> easier in future patches.  No functional change.
> 
> Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
> ---

I'm not sure that patchwork will find this patch if it doesn't have
[PATCH] in the subject...  But otherwise the patch looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter