linux-kernel - Re: [EXT] Re: [PATCH v8 05/10] dt-bindings: usb: ci-hdrc-usb2-imx: add restrictions for reg, interrupts, clock and clock-names properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 13 Mar 2024 08:25:47 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Xu Yang <xu.yang_2@....com>, Rob Herring <robh@...nel.org>
Cc: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
 "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
 "shawnguo@...nel.org" <shawnguo@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
 "kernel@...gutronix.de" <kernel@...gutronix.de>,
 "festevam@...il.com" <festevam@...il.com>, dl-linux-imx <linux-imx@....com>,
 "peter.chen@...nel.org" <peter.chen@...nel.org>, Jun Li <jun.li@....com>,
 "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH v8 05/10] dt-bindings: usb: ci-hdrc-usb2-imx:
 add restrictions for reg, interrupts, clock and clock-names properties

On 13/03/2024 03:48, Xu Yang wrote:
>>> +
>>> +  # imx7d Soc need one clock
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          items:
>>> +            - const: fsl,imx7d-usb
>>> +            - const: fsl,imx27-usb
>>> +    then:
>>> +      properties:
>>> +        clocks:
>>> +          maxItems: 1
>>> +        clock-names:
>>> +          maxItems: 1
>>
>> What's the name?
> 
> Can I not specify the name since the macro definition for USB

But you must specify name or disallow names (: false).

> controller clock in clock.h is recognizable and the driver doesn't

header has nothing to do with it

> get this clock by name rather index?

Driver does not have to take clocks by names, it does not really matter
to such discussion. If you provide clock-names, then the name should be
defined/fixed.


Best regards,
Krzysztof