[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <878r2mk14a.fsf@mail.parknet.co.jp>
Date: Wed, 13 Mar 2024 17:05:41 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Thadeu Lima de Souza Cascardo <cascardo@...lia.com>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
Gwendal
Grignou <gwendal@...omium.org>, dlunev@...omium.org
Subject: Re: [PATCH] fat: ignore .. subdir and always add a link to dirs
Thadeu Lima de Souza Cascardo <cascardo@...lia.com> writes:
>> You are forgetting to count about normal dirs other than "." and ".."?
>>
>
> Yes, I was not counting those. The patch simply ignores ".." when counting dirs
> (which is used only for determining the number of links), and always adds one
> link. Then, when validating the inode, it also only requires that at least one
> link exists instead of two.
So you break the mkdir/rmdir link counting, isn't it?
Thanks.
> There is only one other instance of fat_subdirs being called and that's when
> the root dir link count is determined. I left that one unchanged, as usually
> "." and ".." does not exist there and we always add two links there.
--
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Powered by blists - more mailing lists