linux-kernel - Re: [PATCH 0/2] media: i2c: Add support for GC05A2 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeHVJpiaCTdQHWQocE9PFLsGhu+a2TP7VSV34i02v-ksA@mail.gmail.com>
Date: Wed, 13 Mar 2024 10:52:39 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Zhi Mao <zhi.mao@...iatek.com>
Cc: mchehab@...nel.org, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, 
	sakari.ailus@...ux.intel.com, laurent.pinchart@...asonboard.com, 
	shengnan.wang@...iatek.com, yaya.chang@...iatek.com, 
	Project_Global_Chrome_Upstream_Group@...iatek.com, yunkec@...omium.org, 
	conor+dt@...nel.org, matthias.bgg@...il.com, 
	angelogioacchino.delregno@...labora.com, jacopo.mondi@...asonboard.com, 
	10572168@...com, hverkuil-cisco@...all.nl, heiko@...ech.de, 
	jernej.skrabec@...il.com, macromorgan@...mail.com, linus.walleij@...aro.org, 
	hdegoede@...hat.com, tomi.valkeinen@...asonboard.com, 
	gerald.loacker@...fvision.net, bingbu.cao@...el.com, 
	dan.scally@...asonboard.com, linux-media@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 0/2] media: i2c: Add support for GC05A2 sensor

On Wed, Mar 13, 2024 at 7:54 AM Zhi Mao <zhi.mao@...iatek.com> wrote:
>
> This series adds YAML DT binding and V4L2 sub-device driver for Galaxycore's
> GC05A2 5-megapixel 10-bit RAW CMOS 1/5" sensor, with an MIPI CSI-2 image data
> interface and the I2C control bus.
>
> The driver is implemented with V4L2 framework.
>  - Async registered as a V4L2 sub-device.
>  - As the first component of camera system including Seninf, ISP pipeline.
>  - A media entity that provides one source pad in common.
>  - Used in camera features on ChromeOS application.
>
> Also this driver supports following features:
>  - manual exposure and analog gain control support
>  - vertical blanking control support
>  - test pattern support
>  - media controller support
>  - runtime PM support
>  - support resolution: 2592x1944@...ps, 1280x720@...ps

Not even going to do a thorough review as one should learn on the
previous reviews. Most of the comments that I had given to another
driver submission are applicable here. So, waiting for v2 with all
applicable being addressed.

-- 
With Best Regards,
Andy Shevchenko