linux-kernel - Re: [PATCH v3 09/12] mm: Take placement mappings gap into account

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <615a783a-0912-4539-94bd-f1e09535bf38@csgroup.eu>
Date: Wed, 13 Mar 2024 09:04:37 +0000
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Rick Edgecombe <rick.p.edgecombe@...el.com>, "Liam.Howlett@...cle.com"
	<Liam.Howlett@...cle.com>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>, "bp@...en8.de" <bp@...en8.de>,
	"broonie@...nel.org" <broonie@...nel.org>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "debug@...osinc.com" <debug@...osinc.com>,
	"hpa@...or.com" <hpa@...or.com>, "keescook@...omium.org"
	<keescook@...omium.org>, "kirill.shutemov@...ux.intel.com"
	<kirill.shutemov@...ux.intel.com>, "luto@...nel.org" <luto@...nel.org>,
	"mingo@...hat.com" <mingo@...hat.com>, "peterz@...radead.org"
	<peterz@...radead.org>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"x86@...nel.org" <x86@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH v3 09/12] mm: Take placement mappings gap into account



Le 12/03/2024 à 23:28, Rick Edgecombe a écrit :
> When memory is being placed, mmap() will take care to respect the guard
> gaps of certain types of memory (VM_SHADOWSTACK, VM_GROWSUP and
> VM_GROWSDOWN). In order to ensure guard gaps between mappings, mmap()
> needs to consider two things:
>   1. That the new mapping isn’t placed in an any existing mappings guard
>      gaps.
>   2. That the new mapping isn’t placed such that any existing mappings
>      are not in *its* guard gaps.
> 
> The long standing behavior of mmap() is to ensure 1, but not take any care
> around 2. So for example, if there is a PAGE_SIZE free area, and a
> mmap() with a PAGE_SIZE size, and a type that has a guard gap is being
> placed, mmap() may place the shadow stack in the PAGE_SIZE free area. Then
> the mapping that is supposed to have a guard gap will not have a gap to
> the adjacent VMA.
> 
> For MAP_GROWSDOWN/VM_GROWSDOWN and MAP_GROWSUP/VM_GROWSUP this has not
> been a problem in practice because applications place these kinds of
> mappings very early, when there is not many mappings to find a space
> between. But for shadow stacks, they may be placed throughout the lifetime
> of the application.
> 
> Use the start_gap field to find a space that includes the guard gap for
> the new mapping. Take care to not interfere with the alignment.
> 
> Signed-off-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
> ---
> v3:
>   - Spelling fix in comment
> 
> v2:
>   - Remove VM_UNMAPPED_START_GAP_SET and have struct vm_unmapped_area_info
>     initialized with zeros (in another patch). (Kirill)
>   - Drop unrelated space change (Kirill)
>   - Add comment around interactions of alignment and start gap step
>     (Kirill)
> ---
>   include/linux/mm.h |  1 +
>   mm/mmap.c          | 12 +++++++++---
>   2 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index d91cde79aaee..deade7be00d0 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -3418,6 +3418,7 @@ struct vm_unmapped_area_info {
>   	unsigned long high_limit;
>   	unsigned long align_mask;
>   	unsigned long align_offset;
> +	unsigned long start_gap;

Only a start_gap is needed ? No need of an end_gap ?

>   };
>   
>   extern unsigned long vm_unmapped_area(struct vm_unmapped_area_info *info);
> diff --git a/mm/mmap.c b/mm/mmap.c
> index b889c79d11bd..634e706fd97e 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -1582,7 +1582,7 @@ static unsigned long unmapped_area(struct vm_unmapped_area_info *info)
>   	MA_STATE(mas, &current->mm->mm_mt, 0, 0);
>   
>   	/* Adjust search length to account for worst case alignment overhead */
> -	length = info->length + info->align_mask;
> +	length = info->length + info->align_mask + info->start_gap;
>   	if (length < info->length)
>   		return -ENOMEM;
>   
> @@ -1594,7 +1594,13 @@ static unsigned long unmapped_area(struct vm_unmapped_area_info *info)
>   	if (mas_empty_area(&mas, low_limit, high_limit - 1, length))
>   		return -ENOMEM;
>   
> -	gap = mas.index;
> +	/*
> +	 * Adjust for the gap first so it doesn't interfere with the
> +	 * later alignment. The first step is the minimum needed to
> +	 * fulill the start gap, the next steps is the minimum to align
> +	 * that. It is the minimum needed to fulill both.
> +	 */
> +	gap = mas.index + info->start_gap;
>   	gap += (info->align_offset - gap) & info->align_mask;
>   	tmp = mas_next(&mas, ULONG_MAX);
>   	if (tmp && (tmp->vm_flags & VM_STARTGAP_FLAGS)) { /* Avoid prev check if possible */
> @@ -1633,7 +1639,7 @@ static unsigned long unmapped_area_topdown(struct vm_unmapped_area_info *info)
>   
>   	MA_STATE(mas, &current->mm->mm_mt, 0, 0);
>   	/* Adjust search length to account for worst case alignment overhead */
> -	length = info->length + info->align_mask;
> +	length = info->length + info->align_mask + info->start_gap;
>   	if (length < info->length)
>   		return -ENOMEM;
>