linux-kernel - Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a1aa580-50b2-4657-8308-94bffb194aea@moroto.mountain>
Date: Wed, 13 Mar 2024 13:17:39 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Prasad Pandit <ppandit@...hat.com>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	linux-arm-kernel@...ts.infradead.org, gregkh@...uxfoundation.org,
	rjui@...adcom.com, sbranden@...adcom.com,
	linux-staging@...ts.linux.dev, linux-rpi-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Prasad Pandit <pjp@...oraproject.org>
Subject: Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to
 Kconifg

Normally, I would let Greg decide to notice or ignore the typo in the
subject but he's on vacation...  s/Kconifg/Kconfig/

On Wed, Mar 13, 2024 at 02:42:59PM +0530, Prasad Pandit wrote:
> From: Prasad Pandit <pjp@...oraproject.org>
> 
> Add terminating new line to the Kconfig file.

Why does this make a difference?  Is it just because it's annoying to
cat a file that doesn't have a newline at the end?  I checked, and it's
not a checkpatch warning.  Perhaps it should be though.

KTODO: make checkpatch.pl warn about files that don't end in a newline

Since you're resending anyway could you add that information to the
commit message?  Something like:  "Add terminating new line to the
Kconfig file.  Otherwise it's annoying to cat files that don't have a
newline.  #PetPeeve".

Just fix the subject and add a line to the commit message and I'll ack
the patch.

regards,
dan carpenter