linux-kernel - Re: [PATCH 00/10] perf: Clean up common uncore boilerplate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b24137db-62e8-2b60-7a8d-2a7f8ac7ba93@arm.com>
Date: Wed, 13 Mar 2024 11:26:07 +0000
From: James Clark <james.clark@....com>
To: Robin Murphy <robin.murphy@....com>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, x86@...nel.org,
 linux-perf-users@...r.kernel.org, jialong.yang@...ngroup.cn,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Will Deacon <will@...nel.org>
Subject: Re: [PATCH 00/10] perf: Clean up common uncore boilerplate



On 12/03/2024 17:34, Robin Murphy wrote:
> Hi all,
> 
> Since this came up yet again recently, and it's an idea which has been
> nagging me for years, I decided it was time to see how hard it really
> would be to start shaving this yak. And it turns out to be refreshingly
> simple - the core code has quietly become capable of doing most of what
> we want, the one new functional addition is trivial (patch #2), and the
> resulting largely-mechanical cleanup seems a pretty nice win.
> 
> This series is focused on drivers/perf/ as that's where most mess is
> concentrated, but figured I'd include the arch/ patches as well since
> they might be reasonable to land with the core changes, at least for x86
> (FWIW I did also look at the powerpc drivers but they scared me and I
> ran away; sorry). The remaining stragglers elsewhere around the tree I'd
> come back to as a follow-up.
> 
> (And yes, I appreciate it's mid-merge-window already, but since I do
> have a tree-wide rename proposed here, may as well give the discussion
> a chance for a head start before -rc1...)
> 
> Thanks,
> Robin.
> 
> 
Reviewed-by: James Clark <james.clark@....com>

> Robin Murphy (10):
>   perf/alibaba_uncore_drw: Use correct CPU affinity
>   perf: Add capability for common event support
>   drivers/perf: Use PERF_PMU_CAP_NO_COMMON_EVENTS
>   perf: Rename PERF_PMU_CAP_NO_INTERRUPT
>   drivers/perf: Use PERF_PMU_CAP_NO_SAMPLING consistently
>   drivers/perf: Clean up redundant per-task checks
>   perf: Define common uncore capabilities
>   drivers/perf: Use common uncore capabilities
>   x86: Use common uncore PMU capabilities
>   ARM: Use common uncore PMU capabilities
> 
>  arch/arc/kernel/perf_event.c              |  2 +-
>  arch/arm/mach-imx/mmdc.c                  | 16 +-------------
>  arch/arm/mm/cache-l2x0-pmu.c              | 12 +---------
>  arch/csky/kernel/perf_event.c             |  2 +-
>  arch/powerpc/perf/8xx-pmu.c               |  2 +-
>  arch/powerpc/perf/hv-24x7.c               |  2 +-
>  arch/powerpc/perf/hv-gpci.c               |  2 +-
>  arch/powerpc/platforms/pseries/papr_scm.c |  2 +-
>  arch/s390/kernel/perf_cpum_cf.c           |  2 +-
>  arch/sh/kernel/perf_event.c               |  2 +-
>  arch/x86/events/amd/iommu.c               | 17 +-------------
>  arch/x86/events/amd/power.c               | 10 +--------
>  arch/x86/events/amd/uncore.c              | 12 +++-------
>  arch/x86/events/core.c                    |  2 +-
>  arch/x86/events/intel/cstate.c            | 16 +++-----------
>  arch/x86/events/intel/uncore.c            | 11 +--------
>  arch/x86/events/intel/uncore_snb.c        | 20 +++--------------
>  arch/x86/events/msr.c                     |  9 +-------
>  arch/x86/events/rapl.c                    |  9 +-------
>  drivers/fpga/dfl-fme-perf.c               |  2 +-
>  drivers/perf/alibaba_uncore_drw_pmu.c     | 27 +++--------------------
>  drivers/perf/amlogic/meson_ddr_pmu_core.c | 11 +--------
>  drivers/perf/arm-cci.c                    | 15 +------------
>  drivers/perf/arm-ccn.c                    | 20 +----------------
>  drivers/perf/arm-cmn.c                    | 10 +--------
>  drivers/perf/arm_cspmu/arm_cspmu.c        | 27 ++---------------------
>  drivers/perf/arm_dmc620_pmu.c             | 18 +--------------
>  drivers/perf/arm_dsu_pmu.c                | 22 +-----------------
>  drivers/perf/arm_pmu_platform.c           |  2 +-
>  drivers/perf/arm_smmuv3_pmu.c             | 15 +------------
>  drivers/perf/arm_spe_pmu.c                |  7 ++----
>  drivers/perf/cxl_pmu.c                    |  8 +------
>  drivers/perf/dwc_pcie_pmu.c               | 13 +----------
>  drivers/perf/fsl_imx8_ddr_perf.c          | 13 +----------
>  drivers/perf/fsl_imx9_ddr_perf.c          | 13 +----------
>  drivers/perf/hisilicon/hisi_pcie_pmu.c    | 10 +--------
>  drivers/perf/hisilicon/hisi_uncore_pmu.c  | 20 +----------------
>  drivers/perf/hisilicon/hns3_pmu.c         |  9 +-------
>  drivers/perf/marvell_cn10k_ddr_pmu.c      | 15 +------------
>  drivers/perf/marvell_cn10k_tad_pmu.c      |  6 +----
>  drivers/perf/qcom_l2_pmu.c                | 21 ++----------------
>  drivers/perf/qcom_l3_pmu.c                | 21 +-----------------
>  drivers/perf/riscv_pmu_sbi.c              |  2 +-
>  drivers/perf/thunderx2_pmu.c              | 17 +-------------
>  drivers/perf/xgene_pmu.c                  | 16 +-------------
>  include/linux/perf_event.h                |  6 ++++-
>  kernel/events/core.c                      |  7 +++++-
>  47 files changed, 67 insertions(+), 456 deletions(-)
>