linux-kernel - Re: [PATCH] PCI: fix link retrain status in pcie_wait_for_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZfGwN0PWF6M9kp0v@localhost>
Date: Wed, 13 Mar 2024 14:55:03 +0100
From: simon.guinot@...uanux.org
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Simon Guinot <simon.guinot@...gate.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"Maciej W . Rozycki" <macro@...am.me.uk>, linux-pci@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org
Subject: Re: [PATCH] PCI: fix link retrain status in
 pcie_wait_for_link_delay()

On Wed, Mar 13, 2024 at 02:00:21PM +0200, Ilpo Järvinen wrote:
> On Wed, 13 Mar 2024, Simon Guinot wrote:
> 
> > The current code in pcie_wait_for_link_delay() handles the value
> > returned by pcie_failed_link_retrain() as an integer, expecting 0
> > when the link has been successfully retrained. The issue is that
> > pcie_failed_link_retrain() returns a boolean: "true" if the link
> > has been successfully retrained and "false" otherwise. This leads
> > pcie_wait_for_link_delay() to return an incorrect "active link"
> > status when pcie_failed_link_retrain() is called.
> > 
> > This patch fixes the check of the value returned by
> > pcie_failed_link_retrain() in pcie_wait_for_link_delay().
> > 
> > Note that this bug induces abnormal timeout delays when a PCI device
> > is unplugged (around 60 seconds per bridge / secondary bus removed).
> > 
> > Cc: stable@...r.kernel.org
> > Fixes: 1abb47390350 ("Merge branch 'pci/enumeration'")
> > Signed-off-by: Simon Guinot <simon.guinot@...gate.com>
> 
> Hi Simon,
> 
> Thanks for your patch. There's, however, already a better series to fix 
> this and other related issues. Bjorn just hasn't gotten into applying them 
> yet:
> 
> https://patchwork.kernel.org/project/linux-pci/list/?series=824858
> 
> (I proposed a patch very similar to yours month ago, but Maciej came up 
> a better way to fix all the issues.)

Hi Ilpo,

Thanks for pointing this patch series. This indeed fixes the timeout delay
issue I observed.

Simon

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)