linux-kernel - Re: [PATCH 2/2] mtd: core: Don't fail mtd_device_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lxl3zzgq4kgbgxkya2c6zyagcnrcyp2lzewu553mkmgdlooeca@m2wyltn7qpog>
Date: Wed, 13 Mar 2024 15:59:02 +0200
From: Aapo Vienamo <aapo.vienamo@...ux.intel.com>
To: Michael Walle <mwalle@...nel.org>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>, 
	Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, 
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH 2/2] mtd: core: Don't fail mtd_device_parse_register() if
 OTP is unsupported

On Wed, Mar 13, 2024 at 10:24:13AM +0100, Michael Walle wrote:
> On Mon Mar 11, 2024 at 5:20 PM CET, Aapo Vienamo wrote:
> > On Mon, Mar 11, 2024 at 03:38:17PM +0100, Michael Walle wrote:
> > > Also, you'll print an error message for EOPNOTSUPP, although that is
> > > not really an error. Is that intended? 
> >
> > Well, when we hit this, the functionality of the SPI memory itself is
> > degraded in the sense that the OTP functionality is not available. What
> > would you suggest?
> 
> But it's not really an error, I mean, we are ignoring that one on
> purpose now :) I'd just guard it with "if (ret != -EOPNOTSUPP)".

To clarify, are you suggesting a modification like this to the code at
the end of mtd_otp_nvmem_add()?

err:
	nvmem_unregister(...);
	if (ret != EOPNOTSUPP)
		return dev_err_probe(...);
	return 0;

Best,
Aapo