linux-kernel - Re: [PATCH] net: dsa: mt7530: increase reset hold time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <757e7f93-9ebd-49e3-afd6-a40eb81a1a49@arinc9.com>
Date: Wed, 13 Mar 2024 18:51:03 +0300
From: Arınç ÜNAL <arinc.unal@...nc9.com>
To: Justin Swartz <justin.swartz@...ingedge.co.za>
Cc: Daniel Golle <daniel@...rotopia.org>, DENG Qingfang <dqfext@...il.com>,
 Sean Wang <sean.wang@...iatek.com>, Andrew Lunn <andrew@...n.ch>,
 Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] net: dsa: mt7530: increase reset hold time

On 13.03.2024 18:38, Justin Swartz wrote:
> On 2024-03-13 17:04, Arınç ÜNAL wrote:
>> On 13.03.2024 16:13, Justin Swartz wrote:
>> I think you've missed that your patch is already applied. And it won't be
>> reverted for reasons explained by Paolo in this mail thread.
>>
>> https://git.kernel.org/netdev/net-next/c/2920dd92b980
>>
>> So if your patch here were to be applied too, the final mt7530.c would have
>> the LEDs disabled AND before reset deassertion delay increased.
> 
> Yes, I seem to have missed that. I thought your request for the
> patch to be reverted definitely would have been performed, or at
> least queued, seeing as you're the maintainer.

Yeah, one would think. :D Since your patch was applied in a good intent of
not having it miss the current development cycle, it was a bit rushed. So
before I could present a valid reason to revert the patch, the pull request
that included your patch was already submitted to Linus. So unless the
patch is something very bad which it's not, nobody's going to bother
reverting it.

I've sent another patch an hour or so ago that reverts it and implements
what we've discussed here. I will also make sure it is applied to stable
trees.

https://lore.kernel.org/all/20240313-for-netnext-mt7530-better-fix-xtal-frequency-v1-1-5a50df99f51a@arinc9.com/

Arınç