Message-ID: <4203654.1IzOArtZ34@jernej-laptop>
Date: Thu, 14 Mar 2024 20:18:12 +0100
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: hitechshell@...l.ru
Cc: Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Samuel Holland <samuel@...lland.org>, Maxime Ripard <mripard@...nel.org>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: sun5i: Add PocketBook 614 Plus support

Dne četrtek, 14. marec 2024 ob 19:18:58 CET je hitechshell@...l.ru napisal(a):
> On Thu, Mar 14, 2024 at 06:14:48PM +0100, Jernej Škrabec wrote:
> > Hi Denis!
> > 
> > Dne četrtek, 14. marec 2024 ob 16:53:06 CET je Denis Burkov napisal(a):
> > > What works:
> > > 
> > > - Serial console
> > > - mmc0, mmc2 (both microSD card slots on the board)
> > > - All buttons (gpio and lradc based)
> > > - Power LED
> > > - PMIC
> > > - RTC
> > > - USB OTG/gadgets mode
> > > 
> > > Signed-off-by: Denis Burkov <hitechshell@...l.ru>
> > > ---
> > >  arch/arm/boot/dts/allwinner/Makefile          |   2 +
> > >  .../sun5i-a13-pocketbook-614-plus.dts         | 254 ++++++++++++++++++
> > >  2 files changed, 256 insertions(+)
> > >  create mode 100644 arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts
> > > 
> > > diff --git a/arch/arm/boot/dts/allwinner/Makefile b/arch/arm/boot/dts/allwinner/Makefile
> > > index 2d26c3397f14..fe321865beed 100644
> > > --- a/arch/arm/boot/dts/allwinner/Makefile
> > > +++ b/arch/arm/boot/dts/allwinner/Makefile
> > > @@ -61,6 +61,7 @@ dtb-$(CONFIG_MACH_SUN5I) += \
> > >  	sun5i-a13-olinuxino.dtb \
> > >  	sun5i-a13-olinuxino-micro.dtb \
> > >  	sun5i-a13-pocketbook-touch-lux-3.dtb \
> > > +	sun5i-a13-pocketbook-614-plus.dtb \
> > >  	sun5i-a13-q8-tablet.dtb \
> > >  	sun5i-a13-utoo-p66.dtb \
> > >  	sun5i-gr8-chip-pro.dtb \
> > > @@ -82,6 +83,7 @@ dtb-$(CONFIG_MACH_SUN5I) += \
> > >  	sun5i-a13-olinuxino.dtb \
> > >  	sun5i-a13-olinuxino-micro.dtb \
> > >  	sun5i-a13-pocketbook-touch-lux-3.dtb \
> > > +	sun5i-a13-pocketbook-614-plus.dtb \
> > >  	sun5i-a13-q8-tablet.dtb \
> > >  	sun5i-a13-utoo-p66.dtb \
> > >  	sun5i-gr8-chip-pro.dtb \
> > 
> > This merge artefact. Can you add patch before this one and remove duplicate definitions?
> > 
> Sorry, I didn't quite understand. Should I remove the duplicate block in a separate commit? or enable this one?

Yes, remove block in a separate patch, which should be positioned before this one.

> > > diff --git a/arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts b/arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts
> > > new file mode 100644
> > > index 000000000000..89898fa16ff7
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/allwinner/sun5i-a13-pocketbook-614-plus.dts
> > > @@ -0,0 +1,254 @@
> > > +// SPDX-License-Identifier: GPL-2.0+
> > > +/*
> > > + * Copyright 2024 Denis Burkov <hitechshell@...l.ru>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "sun5i-a13.dtsi"
> > > +#include "sunxi-common-regulators.dtsi"
> > 
> > Extra empty line here.
> > 
> > > +#include <dt-bindings/gpio/gpio.h>
> > > +#include <dt-bindings/input/input.h>
> > > +#include <dt-bindings/interrupt-controller/irq.h>
> > > +
> > > +/ {
> > > +	model = "PocketBook 614 Plus";
> > > +	compatible = "pocketbook,614-plus", "allwinner,sun5i-a13";
> > > +
> > > +	aliases {
> > > +		serial0 = &uart1;
> > > +		i2c0 = &i2c0;
> > > +		i2c1 = &i2c1;
> > > +		i2c2 = &i2c2;
> > > +		rtc0 = &pcf8563;
> > 
> > Please drop aliases except serial0.
> > 
> > > +	};
> > > +
> > > +	chosen {
> > > +		stdout-path = "serial0:115200n8";
> > > +	};
> > > +
> > > +	leds {
> > > +		compatible = "gpio-leds";
> > > +		pinctrl-names = "default";
> > > +		pinctrl-0 = <&led_pins_pocketbook>;
> > 
> > Drop pinctrl nodes. GPIOs don't need them.
> > 
> > > +
> > > +		led {
> > > +			gpios = <&pio 4 8 GPIO_ACTIVE_LOW>; /* PE8 */
> > > +			default-state = "on";
> > 
> > Add additional properties, like function and color.
> > 
> > > +		};
> > > +	};
> > > +
> > > +	gpio-keys {
> > > +		compatible = "gpio-keys";
> > > +		autorepeat;
> > 
> > Why is autorepeat needed?
> > 
> > > +		label = "GPIO Keys";
> > 
> > I guess label is self evident and not needed?
> > 
> > > +		pinctrl-names = "default";
> > > +		pinctrl-0 = <&pocketbook_btn_pins>;
> > 
> > Again, GPIOs don't need pinctrl nodes. I know that you specified pull up, but
> > please try without. Other boards have same design and it's not needed.
> > 
> > > +
> > > +		key-right {
> > > +			label = "Right";
> > > +			linux,code = <KEY_NEXT>;
> > > +			gpios = <&pio 6 9 GPIO_ACTIVE_LOW>; /* PG9 */
> > > +		};
> > > +
> > > +		key-left {
> > > +			label = "Left";
> > > +			linux,code = <KEY_PREVIOUS>;
> > > +			gpios = <&pio 6 10 GPIO_ACTIVE_LOW>; /* PG10 */
> > > +		};
> > > +	};
> > > +
> > > +	reg_3v3_mmc0: regulator-mmc0 {
> > > +		compatible = "regulator-fixed";
> > > +		regulator-name = "vdd-mmc0";
> > > +		regulator-min-microvolt = <3300000>;
> > > +		regulator-max-microvolt = <3300000>;
> > > +		pinctrl-names = "default";
> > > +		pinctrl-0 = <&pocketbook_reg_mmc0_pins>;
> > 
> > again, pinctrl not needed.
> > 
> > > +		gpio = <&pio 4 4 GPIO_ACTIVE_LOW>; /* PE4 */
> > > +		vin-supply = <&reg_vcc3v3>;
> > > +	};
> > > +};
> > > +
> > > +&cpu0 {
> > > +	cpu-supply = <&reg_dcdc2>;
> > > +};
> > > +
> > > +&ehci0 {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&i2c0 {
> > > +	status = "okay";
> > > +
> > > +	axp209: pmic@34 {
> > > +		compatible = "x-powers,axp209";
> > > +		reg = <0x34>;
> > > +		interrupts = <0>;
> > > +	};
> > > +};
> > > +
> > > +#include "axp209.dtsi"
> > > +
> > > +&i2c1 {
> > > +	status = "okay";
> > > +
> > > +	pcf8563: rtc@51 {
> > > +		compatible = "nxp,pcf8563";
> > > +		reg = <0x51>;
> > > +		#clock-cells = <0>;
> > > +	};
> > > +};
> > > +
> > > +&i2c2 {
> > > +	status = "okay";
> > > +
> > > +	/* Touchpanel is connected here. */
> > 
> > Any reason why don't you specify touch panel device here?
> > 
> My mistake, I copied this node from another device. This device does not have a touchpanel at all.
> > > +};
> > > +
> > > +&lradc {
> > > +	vref-supply = <&reg_ldo2>;
> > > +	status = "okay";
> > > +
> > > +	button-300 {
> > > +		label = "Down";
> > > +		linux,code = <KEY_DOWN>;
> > > +		channel = <0>;
> > > +		voltage = <300000>;
> > > +	};
> > > +
> > > +	button-700 {
> > > +		label = "Up";
> > > +		linux,code = <KEY_UP>;
> > > +		channel = <0>;
> > > +		voltage = <700000>;
> > > +	};
> > > +
> > > +	button-1000 {
> > > +		label = "Left";
> > > +		linux,code = <KEY_LEFT>;
> > > +		channel = <0>;
> > > +		voltage = <1000000>;
> > > +	};
> > > +
> > > +	button-1200 {
> > > +		label = "Menu";
> > > +		linux,code = <KEY_MENU>;
> > > +		channel = <0>;
> > > +		voltage = <1200000>;
> > > +	};
> > > +
> > > +	button-1500 {
> > > +		label = "Right";
> > > +		linux,code = <KEY_RIGHT>;
> > > +		channel = <0>;
> > > +		voltage = <1500000>;
> > > +	};
> > > +};
> > > +
> > > +&mmc0 {
> > > +	vmmc-supply = <&reg_3v3_mmc0>;
> > > +	bus-width = <4>;
> > > +	cd-gpios = <&pio 6 0 GPIO_ACTIVE_LOW>; /* PG0 */
> > > +	status = "okay";
> > > +};
> > > +
> > > +&mmc2 {
> > > +	pinctrl-names = "default";
> > > +	pinctrl-0 = <&mmc2_4bit_pc_pins>;
> > > +	vmmc-supply = <&reg_vcc3v3>;
> > > +	bus-width = <4>;
> > > +	non-removable;
> > > +	status = "okay";
> > > +};
> > > +
> > > +&ohci0 {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&otg_sram {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&pio {
> > > +	led_pins_pocketbook: led-pin {
> > > +		pins = "PE8";
> > > +		function = "gpio_out";
> > > +	};
> > > +	pocketbook_btn_pins: btn-pins {
> > > +		pins = "PG9", "PG10";
> > > +		function = "gpio_in";
> > > +		bias-pull-up;
> > > +	};
> > > +	pocketbook_reg_mmc0_pins: reg-mmc0-pins {
> > > +		pins = "PE4";
> > > +		function = "gpio_out";
> > > +	};
> > > +};
> > 
> > Whole PIO node can be dropped.
> > 
> > Best regards,
> > Jernej
> > 
> > > +
> > > +&reg_dcdc2 {
> > > +	regulator-always-on;
> > > +	regulator-min-microvolt = <1000000>;
> > > +	regulator-max-microvolt = <1500000>;
> > > +	regulator-name = "vdd-cpu";
> > > +};
> > > +
> > > +&reg_dcdc3 {
> > > +	regulator-always-on;
> > > +	regulator-min-microvolt = <1000000>;
> > > +	regulator-max-microvolt = <1400000>;
> > > +	regulator-name = "vdd-int-dll";
> > > +};
> > > +
> > > +&reg_ldo1 {
> > > +	regulator-name = "vdd-rtc";
> > > +};
> > > +
> > > +&reg_ldo2 {
> > > +	regulator-always-on;
> > > +	regulator-min-microvolt = <3000000>;
> > > +	regulator-max-microvolt = <3000000>;
> > > +	regulator-name = "avcc";
> > > +};
> > > +
> > > +&reg_ldo3 {
> > > +	regulator-min-microvolt = <3300000>;
> > > +	regulator-max-microvolt = <3300000>;
> > > +	regulator-name = "vcc-wifi";
> > > +};
> > > +
> > > +&reg_usb0_vbus {
> > > +	status = "okay";
> > > +	gpio = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */
> > > +};
> > > +
> > > +&reg_usb1_vbus {
> > > +	gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>; /* PG11 */
> > > +	status = "okay";
> > > +};
> > > +
> > > +&uart1 {
> > > +	pinctrl-names = "default";
> > > +	pinctrl-0 = <&uart1_pg_pins>;
> > > +	status = "okay";
> > > +};
> > > +
> > > +&usb_otg {
> > > +	dr_mode = "otg";
> > > +	status = "okay";
> > > +};
> > > +
> > > +&usb_power_supply {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&battery_power_supply {
> > > +	status = "okay";
> > > +};
> > > +
> > > +&usbphy {
> > > +	usb0_id_det-gpios = <&pio 6 2 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PG2 */

I missed this before, but is pull up property really needed? It doesn't make
much sense.

> > > +	usb0_vbus_det-gpios = <&axp_gpio 1 GPIO_ACTIVE_HIGH>;
> > > +	usb0_vbus-supply = <&reg_usb0_vbus>;
> > > +	usb1_vbus-supply = <&reg_usb1_vbus>;
> > > +	status = "okay";
> > > +};
> > > 
> > 
> > 
> > 
> > 
> Yes, everything works without pincrtl. One guy told me that I need to specify pinctrl for each pin used.

pinctrl node is only needed when multiplexed pin is used for something else than GPIO.

Best regards,
Jernej

> Thanks for the review.
> Best regards,
> Denis
> 

Powered by blists - more mailing lists