linux-kernel - Re: [PATCH net-next v3] Revert "net: Re-use and set mono_delivery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 14 Mar 2024 22:14:01 +0100
From: Daniel Borkmann <daniel@...earbox.net>
To: Abhishek Chauhan <quic_abchauha@...cinc.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Andrew Halaney <ahalaney@...hat.com>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Martin KaFai Lau <martin.lau@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>
Cc: kernel@...cinc.com, bpf@...r.kernel.org
Subject: Re: [PATCH net-next v3] Revert "net: Re-use and set
 mono_delivery_time bit for userspace tstamp packets"

On 3/14/24 8:24 PM, Abhishek Chauhan wrote:
> This reverts commit 885c36e59f46375c138de18ff1692f18eff67b7f.
> 
> The patch currently broke the bpf selftest test_tc_dtime because
> uapi field __sk_buff->tstamp_type depends on skb->mono_delivery_time which
> does not necessarily mean mono with the original fix as the bit was re-used
> for userspace timestamp as well to avoid tstamp reset in the forwarding
> path. To solve this we need to keep mono_delivery_time as is and
> introduce another bit called user_delivery_time and fall back to the
> initial proposal of setting the user_delivery_time bit based on
> sk_clockid set from userspace.
> 
> Fixes: 885c36e59f46 ("net: Re-use and set mono_delivery_time bit for userspace tstamp packets")
> Link: https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/
> Signed-off-by: Abhishek Chauhan <quic_abchauha@...cinc.com>

[ Side note: target tree for this fix is net not net-next, the follow-up
   work would be net-next then. ]

Acked-by: Daniel Borkmann <daniel@...earbox.net>