linux-kernel - Re: [PATCH 1/5] dt-bindings: pinctrl: qcom-pmic-gpio: add PMXR2230 and PM6450 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 14 Mar 2024 22:19:45 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Anjelique Melendez <quic_amelende@...cinc.com>, andersson@...nel.org,
 konrad.dybcio@...aro.org, linus.walleij@...aro.org, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 quic_subbaram@...cinc.com, quic_collinsd@...cinc.com,
 quic_jprakash@...cinc.com
Subject: Re: [PATCH 1/5] dt-bindings: pinctrl: qcom-pmic-gpio: add PMXR2230
 and PM6450 binding

On 14/03/2024 21:04, Anjelique Melendez wrote:
> From: David Collins <quic_collinsd@...cinc.com>
> 
> Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation
> to inclde compatible strings for PMXR2230 and PM6450 PMICs.

Typo, include

Two commits and quite different subjects... Please make it somehow
consistent. Prefix is qcom,pmic-gpio, not qcom-pmic-gpio. Start either
with capital or lower case - just choose one pattern.

A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof