linux-kernel - Re: [PATCH 1/1] PCI: Use the correct bit in Link Training not active check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2403142145010.37739@angie.orcam.me.uk>
Date: Thu, 14 Mar 2024 21:58:11 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
cc: Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] PCI: Use the correct bit in Link Training not active
 check

On Thu, 14 Mar 2024, Ilpo Järvinen wrote:

> One more point to add here, I started to wonder today why that use_lt 
> parameter is needed at all for pcie_retrain_link()?
> 
> Once the Target Speed has been changed to 2.5GT/s which is what the quirk 
> does before calling retraining, LT too should work "normally" after that.

 We don't know if the link is going to become stable with the TLS update 
to 2.5GT/s and we want to ensure that the link has reached the active 
state before claiming victory; LT clear does not mean the link is active, 
it only means what it means, that is that the link isn't being trained at 
the moment.

 Also we don't want to reset the TLS to the maximum before the link has 
become active.

 Does this answer your question?

  Maciej