linux-kernel - Re: [RESEND v4 3/3] arm64: dts: qcom: sc7280: Add power-domains for cpuidle states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=XWH+Eoa9XjDns--NSDTZHeUwTdrX_r_QZhSPpbZNwz+w@mail.gmail.com>
Date: Thu, 14 Mar 2024 16:20:59 -0700
From: Doug Anderson <dianders@...omium.org>
To: Maulik Shah <quic_mkshah@...cinc.com>
Cc: andersson@...nel.org, ulf.hansson@...aro.org, swboyd@...omium.org, 
	wingers@...gle.com, daniel.lezcano@...aro.org, rafael@...nel.org, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, sudeep.holla@....com, jwerner@...omium.org, 
	quic_lsrao@...cinc.com, quic_rjendra@...cinc.com, devicetree@...r.kernel.org, 
	Abhinav Kumar <quic_abhinavk@...cinc.com>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Rob Clark <robdclark@...omium.org>
Subject: Re: [RESEND v4 3/3] arm64: dts: qcom: sc7280: Add power-domains for
 cpuidle states

Hi,

On Mon, Jul 3, 2023 at 1:56 AM Maulik Shah <quic_mkshah@...cinc.com> wrote:
>
> Add power-domains for cpuidle states to use psci os-initiated idle states.
>
> Cc: devicetree@...r.kernel.org
> Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>
> Signed-off-by: Maulik Shah <quic_mkshah@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 98 +++++++++++++++++++++-------
>  1 file changed, 73 insertions(+), 25 deletions(-)

FWIW, I dug up an old sc7280-herobrine board to test some other change
and found it no longer booted. :( I bisected it and this is the change
that breaks it. Specifically, I can make mainline boot with:

git revert --no-edit db5d137e81bc # arm64: dts: qcom: sc7280: Update
domain-idle-states for cluster sleep
git revert --no-edit 7925ca85e956 # arm64: dts: qcom: sc7280: Add
power-domains for cpuidle states

(I get an ath11k crash after that, but that's easy to hack out since I
don't need WiFi)

I suppose the two options here are to either:

1. Track the problem down and figure out why the breaks boot and then
fix it. I'm personally not going to track this down, but if someone
wants me to test a patch I can do that.

2. Delete all the herobrine dts files.

So far we've been keeping the herobrine dts files alive because I
thought some graphics folks (Rob, Abhinav, Jessica, for instance) were
still using it. ...but Rob says he hasn't booted his in a while. No
idea if Abhinav and Jessica are using theirs. Any opinions? Is
herobrine hardware support near and dear to anyone these days?

-Doug