linux-kernel - Re: [PATCH] arm64: dts: qcom: sdm630-nile: add pinctrl for camera key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240315002338.3fe1dcfc@probook>
Date: Fri, 15 Mar 2024 00:23:38 +0100
From: Sebastian Raase <basti@...a.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Sebastian Raase <linux@...a.de>, marijn.suijten@...ainline.org, Bjorn
 Andersson <andersson@...nel.org>, Konrad Dybcio <konrad.dybcio@...aro.org>,
 Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm630-nile: add pinctrl for camera
 key

Hi Krzysztof,

On Thu, 14 Mar 2024 21:37:30 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 14/03/2024 21:00, Sebastian Raase wrote:
> > Add pinctrl configuration for gpio-keys. Without this,
> > camera button half-presses are not detected.
> > 
> > Tested on discovery and pioneer.
> > 
> > Fixes: e781633b6067 ("arm64: dts: qcom: Add support for Sony Xperia XA2/Plus/Ultra (Nile platform)")
> > Signed-off-by: Sebastian Raase <linux@...a.de>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi
> > index 87d0293c728d..5eedca6f288f 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi
> > @@ -90,6 +90,8 @@ cam_vana_rear_vreg: cam-vana-rear-regulator {
> >  
> >  	gpio-keys {
> >  		compatible = "gpio-keys";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&gpio_keys_default>;  
> 
> A nit: Please reverse the order: pinctrl-0 then names

All existing pinctrl definitions use pinctrl-names first, so I followed the existing file. Is this still okay?

> >  
> >  		key-camera-focus {
> >  			label = "Camera Focus";
> > @@ -635,6 +637,13 @@ ts_lcd_id_active: ts-lcd-id-active-state {
> >  		bias-disable;
> >  	};
> >  
> > +	gpio_keys_default: gpio-keys-default {  
> 
> Looks missing suffix (state) and test, so:
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).

I did add the suffix and ran the test, and the warning is gone now. Sent an updated patch.

> Best regards,
> Krzysztof

Best Regards,
Sebastian