linux-kernel - Re: [PATCH] nvme-multipath: fix bogus request queue reference put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c934831a-ec84-4ea4-a156-782880086ffe@kylinos.cn>
Date: Thu, 14 Mar 2024 14:13:39 +0800
From: mengfanhui <mengfanhui@...inos.cn>
To: Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>
Cc: kbusch@...nel.org, axboe@...nel.dk, linux-kernel@...r.kernel.org,
 linux-nvme@...ts.infradead.org
Subject: Re: [PATCH] nvme-multipath: fix bogus request queue reference put

Purpose that to check if we ever added a live path (using
NVME_NS_HEAD_HAS_DISK flag) and if not, clear the disk->queue
reference.The purpose is to perform security checks and remove the disk.


在 2024/1/17 22:39, Christoph Hellwig 写道:
> On Wed, Jan 17, 2024 at 04:04:12PM +0200, Sagi Grimberg wrote:
>> How did you see this? disk->queue is allocated in blk_alloc_disk called
>> in nvme_mpath_alloc_disk... I don't understand how you saw the same
>> dereference that was addressed by this commit.
> 
> This looks like a backport of an old patch of yours to a geriatric
> kernel to me..