linux-kernel - Re: [PATCH] arm64: dts: qcom: sm8650: Add three missing fastrpc-compute-cb nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7ac2b10-eee3-4269-85e4-a68d24c2337a@linaro.org>
Date: Thu, 14 Mar 2024 07:55:59 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Ling Xu <quic_lxu5@...cinc.com>, andersson@...nel.org,
 konrad.dybcio@...aro.org, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: quic_ekangupt@...cinc.com, kernel@...cinc.com,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8650: Add three missing
 fastrpc-compute-cb nodes

On 14/03/2024 07:33, Ling Xu wrote:
> Add three missing cDSP fastrpc compute-cb nodes for the SM8650 SoC.
> 
> Signed-off-by: Ling Xu <quic_lxu5@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 29 ++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index ba72d8f38420..c238ad1be0d4 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -5084,6 +5084,35 @@
>  							 <&apps_smmu 0x19c8 0x0>;
>  						dma-coherent;
>  					};
> +
> +					/* note: secure cb9 in downstream */
> +
> +					compute-cb@10 {
> +						compatible = "qcom,fastrpc-compute-cb";
> +						reg = <12>;
> +						iommus = <&apps_smmu 0x196C 0x0000>,
> +							 <&apps_smmu 0x0C0C 0x0020>,
> +							 <&apps_smmu 0x19CC 0x0000>;

Lowercase hex. Please look at the code above, don't copy downstream
code. This applies to all your work: don't send us downstream code, but
clean it up from all of its problems.

Best regards,
Krzysztof