linux-kernel - Re: [PATCH v2] spi: Fix error code checking in spi_mem_exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 14 Mar 2024 08:07:35 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: linux-spi@...r.kernel.org, Michael Walle <mwalle@...nel.org>, Pratyush
 Yadav <pratyush@...nel.org>, Mark Brown <broonie@...nel.org>, Michael Walle
 <michael@...le.cc>, "Chia-Lin Kao (AceLan)" <acelan.kao@...onical.com>,
 Mika Westerberg <mika.westerberg@...ux.intel.com>,
 linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH v2] spi: Fix error code checking in spi_mem_exec_op()

Hi Florian,

florian.fainelli@...adcom.com wrote on Wed, 13 Mar 2024 12:45:30 -0700:

> After commit cff49d58f57e ("spi: Unify error codes by replacing -ENOTSUPP with
> -EOPNOTSUPP"), our SPI NOR flashes would stop probing with the following
> visible in the kernel log:
> 
> [    2.196300] brcmstb_qspi f0440920.qspi: using bspi-mspi mode
> [    2.210295] spi-nor: probe of spi1.0 failed with error -95
> 
> It turns out that the check in spi_mem_exec_op() was changed to check
> for -ENOTSUPP (old error code) or -EOPNOTSUPP (new error code), but this
> means that for drivers that were converted, the second condition is now
> true, and we stop falling through like we used to. Fix the error to
> check for neither error being neither -ENOTSUPP *nor* -EOPNOTSUPP.
> 
> Fixes: cff49d58f57e ("spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP")
> Reviewed-by: Michael Walle <mwalle@...nel.org>
> Reviewed-by: Pratyush Yadav <pratyush@...nel.org>
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>

Thanks for the fix!

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>