linux-kernel - Re: [PATCH] cdx: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7035e229-569d-4cf5-acc3-6ea575e859b0@amd.com>
Date: Thu, 14 Mar 2024 14:01:04 +0530
From: "Gupta, Nipun" <nipun.gupta@....com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Abhijit Gangurde <abhijit.gangurde@....com>,
 Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>,
 Puneet Gupta <puneet.gupta@....com>, Rob Herring <robh@...nel.org>,
 linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] cdx: Convert to platform remove callback returning void


On 3/8/2024 2:21 PM, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Nipun Gupta <nipun.gupta@....com>