linux-kernel - RE: [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 14 Mar 2024 02:01:18 +0000
From: Peng Fan <peng.fan@....com>
To: Linus Walleij <linus.walleij@...aro.org>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>, Sascha Hauer <kernel@...gutronix.de>
CC: "sudeep.holla@....com" <sudeep.holla@....com>, "cristian.marussi@....com"
	<cristian.marussi@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, Aisheng Dong <aisheng.dong@....com>, Nitin Garg
	<nitin.garg_3@....com>, Ranjani Vaidyanathan <ranjani.vaidyanathan@....com>,
	Ye Li <ye.li@....com>
Subject: RE: [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type

Hi Linus,

Sorry for late reply.

> Subject: Re: [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type
> 
> On Fri, Feb 23, 2024 at 8:07 AM Peng Fan (OSS) <peng.fan@....nxp.com>
> wrote:
> 
> > From: Peng Fan <peng.fan@....com>
> >
> > i.MX95 System Manager FW supports SCMI PINCTRL protocol, but uses
> OEM
> > Pin Configuration type, so extend the driver to support custom params.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> 
> I can't really say much about this as pinctrl maintainer other than that it
> makes me a bit unhappy that i.MX95 is not using the "default"
> SCMI pinctrl bindings.

Sorry about that. I check with our SCMI firmware owner, we could
not afford the memory size, it would require a massive amount of
data in arrays to match pins with functions and then figure out the
mux value for that pin
> 
> If the spec allows for this, and NXP Freescale is using it, I will just have to
> accept it.

In the spec, Table 24 Pin Configuration Type and Enumerations, 192 -255
is for OEM specific units

> 
> It feels like that's the old NXP Freescale pin controller living on just hidden
> behind SCMI, so potentially it should also share code with the old i.MX pin
> controller driver. But I think you wrote part of that driver so you would be the
> best to ask about that in any case I think?

The scmi imx extension code not able to share code with the non-scmi code,
The scmi protocol requires config type and config value, so we need new
way to pack the data.

Thanks,
Peng.
 
> 
> Yours,
> Linus Walleij