linux-kernel - [PATCH] usb: storage: isd200: fix error checks in isd200_{read,write}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Thu, 14 Mar 2024 12:31:36 +0300
From: Roman Smirnov <r.smirnov@....ru>
To: Alan Stern <stern@...land.harvard.edu>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>
CC: Roman Smirnov <r.smirnov@....ru>, <linux-usb@...r.kernel.org>,
	<usb-storage@...ts.one-eyed-alien.net>, <linux-kernel@...r.kernel.org>,
	Sergey Shtylyov <s.shtylyov@....ru>, Karina Yankevich <k.yankevich@....ru>,
	<lvc-project@...uxtesting.org>, <stable@...r.kernel.org>
Subject: [PATCH] usb: storage: isd200: fix error checks in  isd200_{read,write}_config()

The expression result >= 0 will be true even if usb_stor_ctrl_transfer()
returns an error code. It is necessary to compare result with
USB_STOR_XFER_GOOD.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Signed-off-by: Roman Smirnov <r.smirnov@....ru>
Cc: stable@...r.kernel.org
Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
---
 drivers/usb/storage/isd200.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
index 300aeef160e7..2a1531793820 100644
--- a/drivers/usb/storage/isd200.c
+++ b/drivers/usb/storage/isd200.c
@@ -774,7 +774,7 @@ static int isd200_write_config( struct us_data *us )
 		(void *) &info->ConfigData, 
 		sizeof(info->ConfigData));
 
-	if (result >= 0) {
+	if (result == USB_STOR_XFER_GOOD) {
 		usb_stor_dbg(us, "   ISD200 Config Data was written successfully\n");
 	} else {
 		usb_stor_dbg(us, "   Request to write ISD200 Config Data failed!\n");
@@ -816,7 +816,7 @@ static int isd200_read_config( struct us_data *us )
 		sizeof(info->ConfigData));
 
 
-	if (result >= 0) {
+	if (result == USB_STOR_XFER_GOOD) {
 		usb_stor_dbg(us, "   Retrieved the following ISD200 Config Data:\n");
 #ifdef CONFIG_USB_STORAGE_DEBUG
 		isd200_log_config(us, info);
-- 
2.34.1