linux-kernel - Re: [syzbot] [overlayfs?] WARNING in ovl_copy_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpegu8Rjj1cHkB6JD=TY1CWuVaH8YpSRLQe0cOfG9aQXj6Vw@mail.gmail.com>
Date: Thu, 14 Mar 2024 10:38:33 +0100
From: Miklos Szeredi <miklos@...redi.hu>
To: Amir Goldstein <amir73il@...il.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-unionfs@...r.kernel.org, syzkaller-bugs@...glegroups.com, 
	syzbot <syzbot+3abd99031b42acf367ef@...kaller.appspotmail.com>
Subject: Re: [syzbot] [overlayfs?] WARNING in ovl_copy_up_file

On Wed, 13 Mar 2024 at 21:55, Amir Goldstein <amir73il@...il.com> wrote:

> The WARN_ON that I put in ovl_verify_area() may be too harsh.
> I think they can happen if lower file is changed (i_size) while file is being
> copied up after reading i_size into the copy length and this could be
> the case with this syzbot reproducer that keeps mounting overlayfs
> instances over same path.
>
> Should probably demote those WARN_ON to just returning EIO?

Sounds good.

Thanks,
Miklos