linux-kernel - Re: [PATCH v2 3/3] arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8365f7f-fde1-464a-959b-4d7d8541ce18@linaro.org>
Date: Thu, 14 Mar 2024 11:05:15 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sumit Garg <sumit.garg@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, stephan@...hold.net,
 caleb.connolly@...aro.org, neil.armstrong@...aro.org,
 laetitia.mariottini@...com, pascal.eberhard@...com, abdou.saker@...com,
 jimmy.lalande@...com, benjamin.missey@....se.com,
 daniel.thompson@...aro.org, linux-kernel@...r.kernel.org,
 Jagdish Gediya <jagdish.gediya@...aro.org>
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: apq8016: Add Schneider HMIBSC
 board DTS

On 14/03/2024 10:17, Sumit Garg wrote:
> 
>                 compatible = "gpio-leds";
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> 
>                 led@5 {
> +                       reg = <5>;
>                         label = "apq8016-hmibsc:green:wlan";
>                         function = LED_FUNCTION_WLAN;
>                         color = <LED_COLOR_ID_YELLOW>;
> @@ -103,6 +106,7 @@ led@5 {
>                 };
> 
>                 led@6 {
> +                       reg = <6>;
>                         label = "apq8016-hmibsc:yellow:bt";
>                         function = LED_FUNCTION_BLUETOOTH;
>                         color = <LED_COLOR_ID_BLUE>;
> 
> But it then broke dtbs_check. Are you aware of any other saner way to
> fix those warnings properly?

You must drop unit address, because it is not applicable, instead of
adding some properties to mask it.

Best regards,
Krzysztof