linux-kernel - Re: [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6a97c53-3220-413d-bc48-f23119c86ce3@linaro.org>
Date: Thu, 14 Mar 2024 11:15:05 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>
Cc: Ajit Pandey <quic_ajipan@...cinc.com>,
 Imran Shaik <quic_imrashai@...cinc.com>, Taniya Das <quic_tdas@...cinc.com>,
 Jagadeesh Kona <quic_jkona@...cinc.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-clk@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc
 bindings

On 14/03/2024 10:13, Satya Priya Kakitapalli (Temp) wrote:
> 
> On 3/13/2024 10:21 PM, Krzysztof Kozlowski wrote:
>> On 13/03/2024 12:08, Satya Priya Kakitapalli wrote:
>>> Update the videocc device tree bindings for sm8150 to align with the
>>> latest convention.
>> Everything is an update. Please explain what you did and why. The "why"
>> part you tried to cover but I just don't understand what is "align with
>> the latest convention". What convention?
> 
> 
> As per the recent upstream discussions, it is recommended to use 
> index-based lookup instead of using clock names. The current bindings is 
> not aligned with this, hence updating. I'll add the details to commit text.

Yes, please.

> 
> 
>>> Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
>> What is the bug being fixed here?
> 
> 
> There are 2 clocks required for this, AHB and XO. Only one clock is 
> mentioned in the bindings for SM8150, this is one of the reasons to move 
> to latest sm8450 bindings apart from clock names. Hence added a Fixes tag.

This should be in the commit msg.


Best regards,
Krzysztof