linux-kernel - Re: [PATCH] arm64: dts: qcom: apq8016-sbc: correct GPIO LEDs node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be10984c-67ff-4c98-be96-91ccd7205b90@linaro.org>
Date: Thu, 14 Mar 2024 12:31:17 +0100
From: neil.armstrong@...aro.org
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Sumit Garg <sumit.garg@...aro.org>
Subject: Re: [PATCH] arm64: dts: qcom: apq8016-sbc: correct GPIO LEDs node
 names

On 14/03/2024 12:26, Krzysztof Kozlowski wrote:
> Individual LEDs in a GPIO LEDs device node are not addressable, thus
> unit address is not correct.
> 
> dtc is also not happy:
> 
>    Warning (unit_address_vs_reg): /leds/led@5: node has a unit name, but no reg or ranges property
> 
> Reported-by: Sumit Garg <sumit.garg@...aro.org>
> Closes: https://lore.kernel.org/all/CAFA6WYNRwF7GqhBk2B7i-deT3aLxNQckhnOasjip2TYm4HZgAw@mail.gmail.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index 9ffad7d1f2b6..aba08424aa38 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -91,7 +91,7 @@ leds {
>   
>   		compatible = "gpio-leds";
>   
> -		led@1 {
> +		led-1 {
>   			label = "apq8016-sbc:green:user1";
>   			function = LED_FUNCTION_HEARTBEAT;
>   			color = <LED_COLOR_ID_GREEN>;
> @@ -100,7 +100,7 @@ led@1 {
>   			default-state = "off";
>   		};
>   
> -		led@2 {
> +		led-2 {
>   			label = "apq8016-sbc:green:user2";
>   			function = LED_FUNCTION_DISK_ACTIVITY;
>   			color = <LED_COLOR_ID_GREEN>;
> @@ -109,7 +109,7 @@ led@2 {
>   			default-state = "off";
>   		};
>   
> -		led@3 {
> +		led-3 {
>   			label = "apq8016-sbc:green:user3";
>   			function = LED_FUNCTION_DISK_ACTIVITY;
>   			color = <LED_COLOR_ID_GREEN>;
> @@ -118,7 +118,7 @@ led@3 {
>   			default-state = "off";
>   		};
>   
> -		led@4 {
> +		led-4 {
>   			label = "apq8016-sbc:green:user4";
>   			color = <LED_COLOR_ID_GREEN>;
>   			gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
> @@ -127,7 +127,7 @@ led@4 {
>   			default-state = "off";
>   		};
>   
> -		led@5 {
> +		led-5 {
>   			label = "apq8016-sbc:yellow:wlan";
>   			function = LED_FUNCTION_WLAN;
>   			color = <LED_COLOR_ID_YELLOW>;
> @@ -136,7 +136,7 @@ led@5 {
>   			default-state = "off";
>   		};
>   
> -		led@6 {
> +		led-6 {
>   			label = "apq8016-sbc:blue:bt";
>   			function = LED_FUNCTION_BLUETOOTH;
>   			color = <LED_COLOR_ID_BLUE>;

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>