linux-kernel - Re: [PATCH] net: txgbe: fix clk_name exceed MAX_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24a7051fdcd1f156c3704bca39e4b3c41dfc7c4b.camel@redhat.com>
Date: Thu, 14 Mar 2024 13:46:01 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: kuba@...nel.org, Ido Schimmel <idosch@...dia.com>
Cc: Duanqiang Wen <duanqiangwen@...-swift.com>, netdev@...r.kernel.org, 
	mengyuanlou@...-swift.com, davem@...emloft.net, edumazet@...gle.com, 
	maciej.fijalkowski@...el.com, andrew@...n.ch, wangxiongfeng2@...wei.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: txgbe: fix clk_name exceed MAX_DEV_ID limits

On Wed, 2024-03-13 at 16:06 +0800, Duanqiang Wen wrote:
> txgbe register clk which name is i2c_designware.pci_dev_id(),
> clk_name will be stored in clk_lookup_alloc. If PCIe bus number
> is larger than 0x39, clk_name size will be larger than 20 bytes.
> It exceeds clk_lookup_alloc MAX_DEV_ID limits. So the driver
> shortened clk_name.
> 
> Fixes: b63f20485e43 ("net: txgbe: Register fixed rate clock")
> Signed-off-by: Duanqiang Wen <duanqiangwen@...-swift.com>

Unrelated to this patch, but more related to the self-test burst this
patch landed into: it looks like that since roughly the net-next PR was
merged back forwarding debug variant of the vxlan-bridge-1q-ipv6-sh and
vxlan-bridge-1d-port-8472-ipv6-sh tests become less stable.

IDK if that was due to some glitch in the AWS hosts or what else. Just
an head-up.

Cheers,

Paolo