linux-kernel - Re: [PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48986334.fMDQidcC6G@diego>
Date: Thu, 14 Mar 2024 14:49:21 +0100
From: Heiko Stübner <heiko@...ech.de>
To: Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Arınç ÜNAL <arinc.unal@...nc9.com>
Cc: mithat.guner@...ont.com, erkin.bozoglu@...ont.com,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f

Hey,

Am Donnerstag, 14. März 2024, 13:37:19 CET schrieb Arınç ÜNAL:
> Hello Heiko.
> 
> On 14.03.2024 15:31, Heiko Stübner wrote:
> > Am Donnerstag, 14. März 2024, 13:24:35 CET schrieb Arınç ÜNAL via B4 Relay:
> >> From: Arınç ÜNAL <arinc.unal@...nc9.com>
> >>
> >> The MT7531 switch listens on PHY address 0x1f on an MDIO bus. I've got two
> >> findings that support this. There's no bootstrapping option to change the
> >> PHY address of the switch. The Linux driver hardcodes 0x1f as the PHY
> >> address of the switch. So the reg property on the device tree is currently
> >> ignored by the Linux driver.
> >>
> >> Therefore, describe the correct PHY address on Banana Pi BPI-R2 Pro that
> >> has this switch.
> >>
> >> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> > 
> > Fixes: c1804463e5c6 ("arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board")
> 
> Do I need to resubmit with this added, or would you add it while applying
> the patch?

nope, all good. b4 am should just pick up this trailer when it downloads
the patch from lore.kernel.org.

That's the reason I added it as a reply, as we're just in the middle of the
merge window right now.

Heiko