linux-kernel - Re: [PATCH] Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240314100103.GC6100@craftyguy.net>
Date: Thu, 14 Mar 2024 10:01:03 -0700
From: Clayton Craft <clayton@...ftyguy.net>
To: Johan Hovold <johan+linaro@...nel.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 Marcel Holtmann <marcel@...tmann.org>, linux-bluetooth@...r.kernel.org,
 linux-kernel@...r.kernel.org, Johan Hovold <johan+linaro@...nel.org>,
 stable@...r.kernel.org, Janaki Ramaiah Thota <quic_janathot@...cinc.com>
Subject: Re: [PATCH] Revert "Bluetooth: hci_qca: Set BDA quirk bit if fwnode
 exists in DT"

On Thu, 14 Mar 2024 09:44:12 +0100 Johan Hovold <johan+linaro@...nel.org> wrote:
> This reverts commit 7dcd3e014aa7faeeaf4047190b22d8a19a0db696.
> 
> Qualcomm Bluetooth controllers like WCN6855 do not have persistent
> storage for the Bluetooth address and must therefore start as
> unconfigured to allow the user to set a valid address unless one has
> been provided by the boot firmware in the devicetree.
> 
> A recent change snuck into v6.8-rc7 and incorrectly started marking the
> default (non-unique) address as valid. This specifically also breaks the
> Bluetooth setup for some user of the Lenovo ThinkPad X13s.
> 
> Note that this is the second time Qualcomm breaks the driver this way
> and that this was fixed last year by commit 6945795bc81a ("Bluetooth:
> fix use-bdaddr-property quirk"), which also has some further details.
> 
> Fixes: 7dcd3e014aa7 ("Bluetooth: hci_qca: Set BDA quirk bit if fwnode exists in DT")
> Cc: stable@...r.kernel.org      # 6.8
> Cc: Janaki Ramaiah Thota <quic_janathot@...cinc.com>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>

Thanks Johan, this revert does indeed fix Bluetooth for me on the X13s.

Reported-by: Clayton Craft <clayton@...ftyguy.net>
Tested-by: Clayton Craft <clayton@...ftyguy.net>

-Clayton