linux-kernel - Re: [PATCH 2/3] net: b43: Convert sprintf/snprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 14 Mar 2024 13:08:53 -0500
From: Larry Finger <Larry.Finger@...inger.net>
To: Li Zhijian <lizhijian@...itsu.com>, linux-kernel@...r.kernel.org
Cc: Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
 b43-dev@...ts.infradead.org
Subject: Re: [PATCH 2/3] net: b43: Convert sprintf/snprintf to sysfs_emit

On 3/14/24 04:48, Li Zhijian wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
> 
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
> 
> sprintf() will be converted as weel if they have.
> 
> Generally, this patch is generated by
> make coccicheck M=<path/to/file> MODE=patch \
> COCCI=scripts/coccinelle/api/device_attr_show.cocci
> 
> No functional change intended
> 
> CC: Larry Finger <Larry.Finger@...inger.net>
> CC: Kalle Valo <kvalo@...nel.org>
> CC: linux-wireless@...r.kernel.org
> CC: b43-dev@...ts.infradead.org
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> ---
> This is a part of the work "Fix coccicheck device_attr_show warnings"[1]
> Split them per subsystem so that the maintainer can review it easily
> [1] https://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@fujitsu.com/
> ---
>   drivers/net/wireless/broadcom/b43/sysfs.c       | 13 ++++---------
>   drivers/net/wireless/broadcom/b43legacy/sysfs.c | 17 +++++++----------
>   2 files changed, 11 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/net/wireless/broadcom/b43/sysfs.c b/drivers/net/wireless/broadcom/b43/sysfs.c
> index 0679d132968f..261b2b746a9c 100644
> --- a/drivers/net/wireless/broadcom/b43/sysfs.c
> +++ b/drivers/net/wireless/broadcom/b43/sysfs.c
> @@ -53,19 +53,14 @@ static ssize_t b43_attr_interfmode_show(struct device *dev,
>   
>   	switch (wldev->phy.g->interfmode) {
>   	case B43_INTERFMODE_NONE:
> -		count =
> -		    snprintf(buf, PAGE_SIZE,
> -			     "0 (No Interference Mitigation)\n");
> +		count = sysfs_emit(buf, "0 (No Interference Mitigation)\n");
>   		break;
>   	case B43_INTERFMODE_NONWLAN:
> -		count =
> -		    snprintf(buf, PAGE_SIZE,
> -			     "1 (Non-WLAN Interference Mitigation)\n");
> +		count = sysfs_emit(buf,
> +				   "1 (Non-WLAN Interference Mitigation)\n");
>   		break;
>   	case B43_INTERFMODE_MANUALWLAN:
> -		count =
> -		    snprintf(buf, PAGE_SIZE,
> -			     "2 (WLAN Interference Mitigation)\n");
> +		count = sysfs_emit(buf, "2 (WLAN Interference Mitigation)\n");
>   		break;
>   	default:
>   		B43_WARN_ON(1);
> diff --git a/drivers/net/wireless/broadcom/b43legacy/sysfs.c b/drivers/net/wireless/broadcom/b43legacy/sysfs.c
> index eec087ca30e6..b1c5ea4750fa 100644
> --- a/drivers/net/wireless/broadcom/b43legacy/sysfs.c
> +++ b/drivers/net/wireless/broadcom/b43legacy/sysfs.c
> @@ -75,16 +75,15 @@ static ssize_t b43legacy_attr_interfmode_show(struct device *dev,
>   
>   	switch (wldev->phy.interfmode) {
>   	case B43legacy_INTERFMODE_NONE:
> -		count = snprintf(buf, PAGE_SIZE, "0 (No Interference"
> -				 " Mitigation)\n");
> +		count = sysfs_emit(buf, "0 (No Interference" " Mitigation)\n");
>   		break;
>   	case B43legacy_INTERFMODE_NONWLAN:
> -		count = snprintf(buf, PAGE_SIZE, "1 (Non-WLAN Interference"
> -				 " Mitigation)\n");
> +		count = sysfs_emit(buf, "1 (Non-WLAN Interference"
> +				   " Mitigation)\n");
>   		break;
>   	case B43legacy_INTERFMODE_MANUALWLAN:
> -		count = snprintf(buf, PAGE_SIZE, "2 (WLAN Interference"
> -				 " Mitigation)\n");
> +		count = sysfs_emit(buf, "2 (WLAN Interference"
> +				   " Mitigation)\n");
>   		break;
>   	default:
>   		B43legacy_WARN_ON(1);
> @@ -155,11 +154,9 @@ static ssize_t b43legacy_attr_preamble_show(struct device *dev,
>   	mutex_lock(&wldev->wl->mutex);
>   
>   	if (wldev->short_preamble)
> -		count = snprintf(buf, PAGE_SIZE, "1 (Short Preamble"
> -				 " enabled)\n");
> +		count = sysfs_emit(buf, "1 (Short Preamble" " enabled)\n");
>   	else
> -		count = snprintf(buf, PAGE_SIZE, "0 (Short Preamble"
> -				 " disabled)\n");
> +		count = sysfs_emit(buf, "0 (Short Preamble" " disabled)\n");
>   
>   	mutex_unlock(&wldev->wl->mutex);
>   

The code changes are OK, but the subject should be "wifi: b43:", not "net: 
b43:". Kalle may be able to correct this when he applies the patch.

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks,

Larry