linux-kernel - Re: [PATCH v5 00/11] IOMMU memory observability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00555af4-8786-b772-7897-aef1e912b368@google.com>
Date: Fri, 15 Mar 2024 14:33:53 -0700 (PDT)
From: David Rientjes <rientjes@...gle.com>
To: Pasha Tatashin <pasha.tatashin@...een.com>, joro@...tes.org
cc: Andrew Morton <akpm@...ux-foundation.org>, alim.akhtar@...sung.com, 
    alyssa@...enzweig.io, asahi@...ts.linux.dev, baolu.lu@...ux.intel.com, 
    bhelgaas@...gle.com, cgroups@...r.kernel.org, corbet@....net, 
    david@...hat.com, dwmw2@...radead.org, hannes@...xchg.org, heiko@...ech.de, 
    iommu@...ts.linux.dev, jernej.skrabec@...il.com, jonathanh@...dia.com, 
    krzysztof.kozlowski@...aro.org, linux-doc@...r.kernel.org, 
    linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
    linux-mm@...ck.org, linux-rockchip@...ts.infradead.org, 
    linux-samsung-soc@...r.kernel.org, linux-sunxi@...ts.linux.dev, 
    linux-tegra@...r.kernel.org, lizefan.x@...edance.com, marcan@...can.st, 
    mhiramat@...nel.org, m.szyprowski@...sung.com, paulmck@...nel.org, 
    rdunlap@...radead.org, robin.murphy@....com, samuel@...lland.org, 
    suravee.suthikulpanit@....com, sven@...npeter.dev, 
    thierry.reding@...il.com, tj@...nel.org, tomas.mudrunka@...il.com, 
    vdumpa@...dia.com, wens@...e.org, will@...nel.org, yu-cheng.yu@...el.com, 
    bagasdotme@...il.com, mkoutny@...e.com
Subject: Re: [PATCH v5 00/11] IOMMU memory observability

On Thu, 22 Feb 2024, Pasha Tatashin wrote:

> Pasha Tatashin (11):
>   iommu/vt-d: add wrapper functions for page allocations
>   iommu/dma: use iommu_put_pages_list() to releae freelist
>   iommu/amd: use page allocation function provided by iommu-pages.h
>   iommu/io-pgtable-arm: use page allocation function provided by
>     iommu-pages.h
>   iommu/io-pgtable-dart: use page allocation function provided by
>     iommu-pages.h
>   iommu/exynos: use page allocation function provided by iommu-pages.h
>   iommu/rockchip: use page allocation function provided by iommu-pages.h
>   iommu/sun50i: use page allocation function provided by iommu-pages.h
>   iommu/tegra-smmu: use page allocation function provided by
>     iommu-pages.h
>   iommu: observability of the IOMMU allocations
>   iommu: account IOMMU allocated memory
> 
>  Documentation/admin-guide/cgroup-v2.rst |   2 +-
>  Documentation/filesystems/proc.rst      |   4 +-
>  drivers/iommu/amd/amd_iommu.h           |   8 -
>  drivers/iommu/amd/init.c                |  91 ++++++------
>  drivers/iommu/amd/io_pgtable.c          |  13 +-
>  drivers/iommu/amd/io_pgtable_v2.c       |  20 +--
>  drivers/iommu/amd/iommu.c               |  13 +-
>  drivers/iommu/dma-iommu.c               |   7 +-
>  drivers/iommu/exynos-iommu.c            |  14 +-
>  drivers/iommu/intel/dmar.c              |  16 +-
>  drivers/iommu/intel/iommu.c             |  47 ++----
>  drivers/iommu/intel/iommu.h             |   2 -
>  drivers/iommu/intel/irq_remapping.c     |  16 +-
>  drivers/iommu/intel/pasid.c             |  18 +--
>  drivers/iommu/intel/svm.c               |  11 +-
>  drivers/iommu/io-pgtable-arm.c          |  15 +-
>  drivers/iommu/io-pgtable-dart.c         |  37 ++---
>  drivers/iommu/iommu-pages.h             | 186 ++++++++++++++++++++++++
>  drivers/iommu/rockchip-iommu.c          |  14 +-
>  drivers/iommu/sun50i-iommu.c            |   7 +-
>  drivers/iommu/tegra-smmu.c              |  18 ++-
>  include/linux/mmzone.h                  |   5 +-
>  mm/vmstat.c                             |   3 +
>  23 files changed, 361 insertions(+), 206 deletions(-)
>  create mode 100644 drivers/iommu/iommu-pages.h
> 

Joerg, is this series anticipated to be queued up in the core branch of 
git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git so it gets into 
linux-next?

This observability seems particularly useful so that we can monitor and 
alert on any unexpected increases (unbounded memory growth from this 
subsystem has in the past caused us issues before the memory is otherwise 
not observable by host software).

Or are we still waiting on code reviews from some folks that we should 
ping?

Thanks!