linux-kernel - Re: [PATCH v3 4/4] rust: add abstraction for `struct page`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ttl7rjtr.fsf@metaspace.dk>
Date: Fri, 15 Mar 2024 09:16:32 +0100
From: Andreas Hindborg <nmi@...aspace.dk>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Matthew Wilcox <willy@...radead.org>,  Andreas Hindborg
 <a.hindborg@...sung.com>,  akpm@...ux-foundation.org,
  alex.gaynor@...il.com,  arnd@...db.de,  arve@...roid.com,
  benno.lossin@...ton.me,  bjorn3_gh@...tonmail.com,  boqun.feng@...il.com,
  brauner@...nel.org,  cmllamas@...gle.com,  gary@...yguo.net,
  gregkh@...uxfoundation.org,  joel@...lfernandes.org,
  keescook@...omium.org,  linux-kernel@...r.kernel.org,
  linux-mm@...ck.org,  maco@...roid.com,  ojeda@...nel.org,
  rust-for-linux@...r.kernel.org,  surenb@...gle.com,  tkjos@...roid.com,
  viro@...iv.linux.org.uk,  wedsonaf@...il.com
Subject: Re: [PATCH v3 4/4] rust: add abstraction for `struct page`

Alice Ryhl <aliceryhl@...gle.com> writes:

> Alice Ryhl <aliceryhl@...gle.com> writes:
>
> Andreas Hindborg: I recall you mentioning that you also needed an
> abstraction for pages. To what extent do these abstractions fit your
> needs? Which gfp flags do you need?
>

I based the block device driver API and null block driver series on v1
of this patch and v3 should still be good for that. The null block
driver uses `Page` indirectly through `UniqueFolio` with `GFP_KERNEL`
alloc flags. I do not need to customize the flags outside of that.

As an aside, I added methods to safely operate on the page contents [1].
`kernel::block::vec::Segment` indirectly uses this to move data to and
from pages [2].

Best regards,
Andreas


[1] https://github.com/metaspace/linux/commit/e88f4dc928233fcedcb0afec40be9bc2f8f74e3b
[2] https://lore.kernel.org/rust-for-linux/87y1akso83.fsf@metaspace.dk/T/#me6497ec69544efd21908f1acc6b3a1ab8b148ba0