[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4ec0fae0-afcd-4b64-bf26-21a7972a5d0f@linaro.org>
Date: Fri, 15 Mar 2024 09:33:25 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sebastian Raase <basti@...a.de>
Cc: Sebastian Raase <linux@...a.de>, marijn.suijten@...ainline.org,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm630-nile: add pinctrl for camera key
On 15/03/2024 00:23, Sebastian Raase wrote:
>>> gpio-keys {
>>> compatible = "gpio-keys";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&gpio_keys_default>;
>>
>> A nit: Please reverse the order: pinctrl-0 then names
>
> All existing pinctrl definitions use pinctrl-names first, so I followed the existing file. Is this still okay?
No, not all. If you are sending v2, why you cannot fix this in new code?
Best regards,
Krzysztof
Powered by blists - more mailing lists