linux-kernel - Re: [PATCH 2/3] net: b43: Convert sprintf/snprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <191ee62c-ab5e-498c-86d1-951771c9834f@fujitsu.com>
Date: Fri, 15 Mar 2024 01:16:07 +0000
From: "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
To: Michael Büsch <m@...s.ch>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Larry
 Finger <Larry.Finger@...inger.net>, Kalle Valo <kvalo@...nel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"b43-dev@...ts.infradead.org" <b43-dev@...ts.infradead.org>
Subject: Re: [PATCH 2/3] net: b43: Convert sprintf/snprintf to sysfs_emit



On 15/03/2024 02:32, Michael Büsch wrote:
> On Thu, 14 Mar 2024 17:48:22 +0800
> Li Zhijian <lizhijian@...itsu.com> wrote:
> 
>>   	case B43legacy_INTERFMODE_NONE:
>> -		count = snprintf(buf, PAGE_SIZE, "0 (No Interference"
>> -				 " Mitigation)\n");
>> +		count = sysfs_emit(buf, "0 (No Interference" " Mitigation)\n");
>>   		break;
> 
>>   	if (wldev->short_preamble)
>> -		count = snprintf(buf, PAGE_SIZE, "1 (Short Preamble"
>> -				 " enabled)\n");
>> +		count = sysfs_emit(buf, "1 (Short Preamble" " enabled)\n");
>>   	else
>> -		count = snprintf(buf, PAGE_SIZE, "0 (Short Preamble"
>> -				 " disabled)\n");
>> +		count = sysfs_emit(buf, "0 (Short Preamble" " disabled)\n");
>>   
> 
> Please either leave the line break in place, or remove the string continuation.

Good catch, i will update it.


Thanks
Zhijian

> 
> 
>