linux-kernel - RE: [PATCH v6 1/2] clk: Provide managed helper to get and enable bulk clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <104401da76cc$ccc772c0$66565840$@samsung.com>
Date: Fri, 15 Mar 2024 17:04:44 +0530
From: "Shradha Todi" <shradha.t@...sung.com>
To: "'Stephen Boyd'" <sboyd@...nel.org>, "'Dan Carpenter'"
	<dan.carpenter@...aro.org>
Cc: <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-pci@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-samsung-soc@...r.kernel.org>, <mturquette@...libre.com>,
	<jingoohan1@...il.com>, <lpieralisi@...nel.org>, <kw@...ux.com>,
	<robh@...nel.org>, <bhelgaas@...gle.com>, <krzysztof.kozlowski@...aro.org>,
	<alim.akhtar@...sung.com>, <linux@...linux.org.uk>,
	<m.szyprowski@...sung.com>, <manivannan.sadhasivam@...aro.org>,
	<pankaj.dubey@...sung.com>, <gost.dev@...sung.com>
Subject: RE: [PATCH v6 1/2] clk: Provide managed helper to get and enable
 bulk clocks



> -----Original Message-----
> From: Stephen Boyd <sboyd@...nel.org>
> Sent: 09 March 2024 06:21
> To: 'Dan Carpenter' <dan.carpenter@...aro.org>; Shradha Todi
> <shradha.t@...sung.com>
> Cc: linux-clk@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> pci@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-samsung-
> soc@...r.kernel.org; mturquette@...libre.com; jingoohan1@...il.com;
> lpieralisi@...nel.org; kw@...ux.com; robh@...nel.org; bhelgaas@...gle.com;
> krzysztof.kozlowski@...aro.org; alim.akhtar@...sung.com;
> linux@...linux.org.uk; m.szyprowski@...sung.com;
> manivannan.sadhasivam@...aro.org; pankaj.dubey@...sung.com;
> gost.dev@...sung.com
> Subject: RE: [PATCH v6 1/2] clk: Provide managed helper to get and enable bulk
> clocks
> 
> Quoting Shradha Todi (2024-03-06 04:13:03)
> > >
> > > When clk_bulk_get_all() returns zero then we return success here.
> > >
> >
> > Yes, we are returning success in case there are no clocks as well. In
> > case there are no clocks defined in the DT-node, then it is assumed
> > that the driver does not need any clock manipulation for driver
> > operation. So the intention here is to continue without throwing
> > error.
> 
> Maybe we shouldn't even return the clks to the caller. Do you have any use for
> the clk pointers?

The intention to return the clk pointers was in the case where caller wants to
manipulate a particular clock in certain conditions. They can obtain the clock pointer
and use clk_set_parent, clk_set_rate on those particular clocks.
But I understand that in that case users can use existing clk_bulk_get_all() API.
So, should I go ahead and send v7?