linux-kernel - Re: [PATCH v3 0/5] s390/vfio-ap: ap_config sysfs attribute for mdevctl automation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 15 Mar 2024 10:48:44 -0400
From: Anthony Krowiak <akrowiak@...ux.ibm.com>
To: "Jason J. Herne" <jjherne@...ux.ibm.com>, linux-s390@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, pasic@...ux.ibm.com, borntraeger@...ibm.com,
        agordeev@...ux.ibm.com, gor@...ux.ibm.com
Subject: Re: [PATCH v3 0/5] s390/vfio-ap: ap_config sysfs attribute for
 mdevctl automation

Unless someone else chooses to review these, my opinion is that they are 
good to go.

On 3/13/24 4:58 PM, Jason J. Herne wrote:
> Mdevctl requires a way to atomically query and atomically update a vfio-ap
> mdev's current state. This patch set creates the ap_config sysfs attribute.
> This new attribute allows reading and writing an mdev's entire state in one go.
> If a newly written state is invalid for any reason the entire state is rejected
> and the target mdev remains unchanged.
>
> Changelog
> ==========
> v3
>    - Optimization: hot unplug functions skip apcb update if nothing was actually
>      unplugged.
>    - Hot unplug functions modified to zero bitmaps before use.
>    - Rename ap_matrix_length_check to ap_matrix_overflow_check
>    - Fixed omissions and errors in several commit messages and the docs.
>    - Added Tested-by tags.
> v2
>    - Rebased patched on top of latest master
>    - Reworked code to fit changes introduced by f848cba767e59
>        s390/vfio-ap: reset queues filtered from the guest's AP config
>    - Moved docs changes to separate patch
>
>
> Jason J. Herne (5):
>    s390/ap: Externalize AP bus specific bitmap reading function
>    s390/vfio-ap: Add sysfs attr, ap_config, to export mdev state
>    s390/vfio-ap: Ignore duplicate link requests in
>      vfio_ap_mdev_link_queue
>    s390/vfio-ap: Add write support to sysfs attr ap_config
>    docs: Update s390 vfio-ap doc for ap_config sysfs attribute
>
>   Documentation/arch/s390/vfio-ap.rst   |  30 ++++
>   drivers/s390/crypto/ap_bus.c          |  13 +-
>   drivers/s390/crypto/ap_bus.h          |  22 +++
>   drivers/s390/crypto/vfio_ap_ops.c     | 220 ++++++++++++++++++++++++--
>   drivers/s390/crypto/vfio_ap_private.h |   6 +-
>   5 files changed, 262 insertions(+), 29 deletions(-)
>