linux-kernel - Re: [PATCH v6 6/9] KVM: nVMX: Use macros and #defines in vmx_restore_vmx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZfRpg/IyJOQf60Wf@intel.com>
Date: Fri, 15 Mar 2024 23:30:11 +0800
From: Zhao Liu <zhao1.liu@...el.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	Paolo Bonzini <pbonzini@...hat.com>,
	Andy Lutomirski <luto@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org, Shan Kang <shan.kang@...el.com>,
	Kai Huang <kai.huang@...el.com>, Xin Li <xin3.li@...el.com>
Subject: Re: [PATCH v6 6/9] KVM: nVMX: Use macros and #defines in
 vmx_restore_vmx_basic()

On Fri, Mar 08, 2024 at 05:27:22PM -0800, Sean Christopherson wrote:
> Date: Fri,  8 Mar 2024 17:27:22 -0800
> From: Sean Christopherson <seanjc@...gle.com>
> Subject: [PATCH v6 6/9] KVM: nVMX: Use macros and #defines in
>  vmx_restore_vmx_basic()
> X-Mailer: git-send-email 2.44.0.278.ge034bb2e1d-goog
> 
> From: Xin Li <xin3.li@...el.com>
> 
> Use macros in vmx_restore_vmx_basic() instead of open coding everything
> using BIT_ULL() and GENMASK_ULL().  Opportunistically split feature bits
> and reserved bits into separate variables, and add a comment explaining
> the subset logic (it's not immediately obvious that the set of feature
> bits is NOT the set of _supported_ feature bits).
> 
> Cc: Shan Kang <shan.kang@...el.com>
> Cc: Kai Huang <kai.huang@...el.com>
> Signed-off-by: Xin Li <xin3.li@...el.com>
> [sean: split to separate patch, write changelog, drop #defines]
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> ---
>  arch/x86/kvm/vmx/nested.c | 25 ++++++++++++++++++-------
>  1 file changed, 18 insertions(+), 7 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@...el.com>