linux-kernel - Re: [PATCH][next] fs/9p: remove redundant pointer v9ses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZfRqohX3x7q2p952@1149290c588b>
Date: Fri, 15 Mar 2024 15:34:58 +0000
From: Eric Van Hensbergen <ericvh@...nel.org>
To: Dominique Martinet <asmadeus@...ewreck.org>
Cc: Colin Ian King <colin.i.king@...il.com>,
	Latchesar Ionkov <lucho@...kov.net>,
	Christian Schoenebeck <linux_oss@...debyte.com>,
	v9fs@...ts.linux.dev, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] fs/9p: remove redundant pointer v9ses

On Mon, Mar 04, 2024 at 09:59:22PM +0900, Dominique Martinet wrote:
> Colin Ian King wrote on Thu, Feb 29, 2024 at 10:22:50PM +0000:
> > Pointer v9ses is being assigned the value from the return of inlined
> > function v9fs_inode2v9ses (which just returns inode->i_sb->s_fs_info).
> > The pointer is not used after the assignment, so the variable is
> > redundant and can be removed.
> > 
> > Cleans up clang scan warnings such as:
> > fs/9p/vfs_inode_dotl.c:300:28: warning: variable 'v9ses' set but not
> > used [-Wunused-but-set-variable]
> 
> Thanks for the patch!
> 
> Eric, this appears to be for your -next tree as it doesn't build on
> master -- didn't notice the [next] in the subject line until I tried...
> (I've just build-checked on your tree and it appears correct there)
> 
> > 
> > Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> 
> Reviewed-by: Dominique Martinet <asmadeus@...ewreck.org>
> 
> -- 
> Dominique

Pulled into my for-next tree, will try to get into a part-2 pull
request.  Thanks.

   -eric